Use Ubuntu for Code Coverage.

[JimBobSquarePants]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
• I have provided test coverage for my change (where applicable)

Description

According to my independent testing the RemoteExecutor still works with Ubuntu so we can use that OS as a workaround for #1376 for now.

[JimBobSquarePants]

Dammit. Code Coverage does not seem to work on Ubuntu

https://github.com/SixLabors/ImageSharp/runs/1242561780?check_suite_focus=true#step:7:26

For a cross platform infrastructure .NET Core testing is depressingly flaky.

[brianpopow]

Dammit. Code Coverage does not seem to work on Ubuntu

https://github.com/SixLabors/ImageSharp/runs/1242561780?check_suite_focus=true#step:7:26

For a cross platform infrastructure .NET Core testing is depressingly flaky.

I think its because the test step uses ci-test.ps1 to execute the tests and generate the coverage report. I guess we need a similar sh script and switch dependent on the os. nevermind, i was not aware of pwsh

[JimBobSquarePants]

@brianpopow Looks like it's a bug in the collector.

https://github.com/SixLabors/ImageSharp/pull/1377/checks?check_run_id=1242883010#step:6:360

[JimBobSquarePants]

Looks like a known issue. Will have a look at the nightlies

coverlet-coverage/coverlet#882

[JimBobSquarePants]

TIL RemoteExecutor doesn't work with Microsoft.Net.Compilers.Toolset 3.7.0 on NET 4.7.2, reverting back to 3.3.1 and everything works.

Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.
[xUnit.net 00:02:14.91]       Stack Trace:
[xUnit.net 00:02:14.91]         
[xUnit.net 00:02:14.91]         Child exception:
[xUnit.net 00:02:14.91]           System.InvalidOperationException: Late bound operations cannot be performed on types or methods for which ContainsGenericParameters is true.
[xUnit.net 00:02:14.91]            at System.Reflection.RuntimeMethodInfo.ThrowNoInvokeException()
[xUnit.net 00:02:14.91]            at System.Reflection.RuntimeMethodInfo.InvokeArgumentsCheck(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[xUnit.net 00:02:14.91]            at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[xUnit.net 00:02:14.91]            at Microsoft.DotNet.RemoteExecutor.Program.Main(String[] args)

[codecov]

Codecov Report

Merging #1377 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
+ Coverage   82.80%   82.85%   +0.05%     
==========================================
  Files         690      690              
  Lines       31033    31074      +41     
  Branches     3512     3512              
==========================================
+ Hits        25696    25747      +51     
+ Misses       4615     4605      -10     
  Partials      722      722              

Flag	Coverage Δ
#unittests	82.85% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...harp/PixelFormats/PixelImplementations/Bgra4444.cs	76.92% <0.00%> (-2.57%)	⬇️
...eSharp/PixelFormats/PixelImplementations/Bgr565.cs	77.50% <0.00%> (-2.50%)	⬇️
...geSharp/PixelFormats/PixelImplementations/Byte4.cs	78.04% <0.00%> (-2.44%)	⬇️
...p/PixelFormats/PixelImplementations/Rgba1010102.cs	78.04% <0.00%> (-2.44%)	⬇️
...eSharp/PixelFormats/PixelImplementations/Short2.cs	61.36% <0.00%> (-2.28%)	⬇️
...xelFormats/PixelImplementations/NormalizedByte4.cs	81.25% <0.00%> (-2.09%)	⬇️
...elFormats/PixelImplementations/NormalizedShort4.cs	81.63% <0.00%> (-2.05%)	⬇️
src/ImageSharp/Color/Color.NamedColors.cs	100.00% <0.00%> (ø)
src/ImageSharp/Color/Color.WebSafePalette.cs	100.00% <0.00%> (ø)
...ImageSharp/PixelFormats/PixelImplementations/A8.cs	56.66% <0.00%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1784a6...fdca787. Read the comment docs.