Change position guard from MustBeLessThanTo to MustBeLessThanOrEqualTo#1291
Merged
JimBobSquarePants merged 1 commit intomasterfrom Jul 27, 2020
Merged
Change position guard from MustBeLessThanTo to MustBeLessThanOrEqualTo#1291JimBobSquarePants merged 1 commit intomasterfrom
JimBobSquarePants merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
=======================================
Coverage 82.70% 82.70%
=======================================
Files 697 697
Lines 30677 30677
Branches 3470 3470
=======================================
Hits 25370 25370
Misses 4604 4604
Partials 703 703
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JimBobSquarePants
approved these changes
Jul 27, 2020
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As the title says: The guard of the position was a bit too strict.