Skip to content

Conversation

@Jaben
Copy link
Contributor

@Jaben Jaben commented May 13, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

@CLAassistant
Copy link

CLAassistant commented May 13, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5e2a7cb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1200   +/-   ##
=========================================
  Coverage          ?   82.58%           
=========================================
  Files             ?      694           
  Lines             ?    30047           
  Branches          ?     3397           
=========================================
  Hits              ?    24814           
  Misses            ?     4535           
  Partials          ?      698           
Flag Coverage Δ
#unittests 82.58% <ø> (?)
Impacted Files Coverage Δ
...Sharp/Processing/IImageProcessingContextFactory.cs 100.00% <0.00%> (ø)
...s/Conversion/Implementation/LmsAdaptationMatrix.cs 100.00% <0.00%> (ø)
...harp/Memory/Allocators/ArrayPoolMemoryAllocator.cs 96.61% <0.00%> (ø)
...lorSpaces/Conversion/ColorSpaceConverterOptions.cs 57.14% <0.00%> (ø)
...TagDataEntries/IccViewingConditionsTagDataEntry.cs 52.00% <0.00%> (ø)
...Processors/Transforms/Resamplers/WelchResampler.cs 100.00% <0.00%> (ø)
src/ImageSharp/ImageFrameCollection.cs 90.00% <0.00%> (ø)
...cessing/Extensions/Filters/BlackWhiteExtensions.cs 100.00% <0.00%> (ø)
.../Formats/Jpeg/Components/Decoder/JpegFileMarker.cs 100.00% <0.00%> (ø)
...ssing/Processors/Dithering/OrderedDitherFactory.cs 100.00% <0.00%> (ø)
... and 684 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2a7cb...a85348d. Read the comment docs.

@JimBobSquarePants
Copy link
Member

Thanks @Jaben If you can please sign the Contributor License Agreement we can get this merged 👍

@JimBobSquarePants JimBobSquarePants merged commit bacd7fc into SixLabors:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants