Skip to content

Conversation

@gregleon
Copy link
Contributor

@gregleon gregleon commented Mar 7, 2020

Prerequisites

  • I have written a descriptive pull-request title

  • I have verified that there are no overlapping pull-requests open

  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.

  • I have provided test coverage for my change (where applicable)

Description

Just a simple typo fix.

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fab07ab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1139   +/-   ##
=========================================
  Coverage          ?   82.27%           
=========================================
  Files             ?      678           
  Lines             ?    29216           
  Branches          ?     3278           
=========================================
  Hits              ?    24038           
  Misses            ?     4483           
  Partials          ?      695           
Flag Coverage Δ
#unittests 82.27% <ø> (?)
Impacted Files Coverage Δ
.../Processing/Extensions/Filters/FilterExtensions.cs 100.00% <ø> (ø)
...ocessors/Transforms/Resamplers/LanczosResampler.cs 100.00% <0.00%> (ø)
...harp/Processing/Processors/Filters/HueProcessor.cs 100.00% <0.00%> (ø)
...p/Metadata/Profiles/Exif/Values/ExifSignedShort.cs 14.28% <0.00%> (ø)
...Metadata/Profiles/Exif/Values/ExifRationalArray.cs 68.00% <0.00%> (ø)
...rp/PixelFormats/Utils/Vector4Converters.Default.cs 100.00% <0.00%> (ø)
src/ImageSharp/GraphicsOptions.cs 100.00% <0.00%> (ø)
.../Metadata/Profiles/ICC/Various/IccTagTableEntry.cs 46.66% <0.00%> (ø)
src/ImageSharp/Formats/Bmp/BmpEncoder.cs 100.00% <0.00%> (ø)
...lorSpaces/Conversion/ColorSpaceConverter.CieLuv.cs 100.00% <0.00%> (ø)
... and 669 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab07ab...e771eb4. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you sign the CLA so we can merge?

@gregleon
Copy link
Contributor Author

gregleon commented Mar 8, 2020

CLA signed

@JimBobSquarePants JimBobSquarePants merged commit 60299fb into SixLabors:master Mar 9, 2020
@gregleon gregleon deleted the patch-1 branch March 9, 2020 15:43
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants