Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The ParallelHelper calculation did not correctly handle certain edge cases when the height of a vertical step exceeded the height/number of steps resulting in RowInterval.MinY greater than RowInterval.MaxY.

This fix returns early in the parallel action when this case is detected. Fixes #1105

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #1106 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
+ Coverage   82.22%   82.23%   +<.01%     
==========================================
  Files         702      702              
  Lines       29159    29175      +16     
  Branches     3296     3298       +2     
==========================================
+ Hits        23977    23993      +16     
  Misses       4491     4491              
  Partials      691      691
Flag Coverage Δ
#unittests 82.23% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...mageSharp/Advanced/ParallelUtils/ParallelHelper.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff371db...b3e0963. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It took me a while to figure out what I was doing here originally 😄

Pushed a few more tests to really make sure it works on supercomputers.

@JimBobSquarePants JimBobSquarePants merged commit 16abb95 into master Feb 5, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/fix-1105 branch February 5, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CloneAs fails with dimensions 374x209 and MaxDegreeOfParallelism=16

3 participants