-
-
Notifications
You must be signed in to change notification settings - Fork 888
Refactor IDisposable pattern #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
- Coverage 89.85% 89.74% -0.11%
==========================================
Files 1098 1098
Lines 48823 48828 +5
Branches 3435 3435
==========================================
- Hits 43870 43821 -49
- Misses 4252 4254 +2
- Partials 701 753 +52
Continue to review full report at Codecov.
|
antonfirsov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with opening up the class hierarchy, otherwise looks good. See also:
https://twitter.com/marcgravell/status/1172053321386987520
|
Gonna merge this without waiting for the build. I don't want to wait 40 minutes and we know it builds/passes tests. |
Prerequisites
Description
Touches #967
IDisposablepattern for images, frames, and processors to work better with inheritance and ensure finalizer suppression.Image<TPixel>is no longer sealed as that prevents extending for potential types likeIntegralImage<TPixel>.ImageFrame<TPixel>is left sealed as inheritance should not be required.