-
-
Notifications
You must be signed in to change notification settings - Fork 889
Closed
Labels
Milestone
Description
-
Image.Loadoverloads are marked as throwingUnknownImageFormatExceptionhowever when the image content is incorrect, we throwImageFormatExceptioninstead. We should consider defining, utilizing and documenting a newInvalidImageContentExceptionfor these cases. Alternatively we can just make the xmldocs to refer toImageFormatException, as an easier solution, but having a separateImageFormatExceptionsubclass seems more correct to me. - In
Image.FromFile.csandImage.FromBytes.cswe do not document the above exceptions at all. -
ImageProcessingExceptionis not documented on the API surface. I would suggest to add it to:Mutate,CloneandIImageProcessor<TPixel>.Execute, however I haven't analyzed the call hierarchy whether it is the correct thing to do. - Review our API if there are any other missing exception docs.
If we decide to indroduce InvalidImageContentException, that part should be probably done for RC1, since it is a breaking change.
James-Jackson-South