-
-
Notifications
You must be signed in to change notification settings - Fork 72
Add FontCollection.AddSystemFontCollection #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 86.91% 87.00% +0.09%
==========================================
Files 98 99 +1
Lines 4654 4656 +2
Branches 758 757 -1
==========================================
+ Hits 4045 4051 +6
+ Misses 484 482 -2
+ Partials 125 123 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/// </summary> | ||
/// <param name="collection">The font collection.</param> | ||
/// <returns>The <see cref="FontCollection"/> containing the system fonts.</returns> | ||
public static FontCollection AddSystemFontCollection(this FontCollection collection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static FontCollection AddSystemFontCollection(this FontCollection collection) | |
public static FontCollection AddSystemFonts(this FontCollection collection) |
reads better and prevents users needing to understand that we have a separate collection for system fonts laying around (that feels like implementation detail to me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that’s better! I chose the original name to match our use of Collection suffix elsewhere but that actually makes things for confusing since thats for ttc files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Prerequisites
Description
Implements
FontCollection.AddSystemFontCollection()
extension and normalizes the process of adding metrics to the underlying collection.