Another infinite loop when rendering text

[Socolin]

Prerequisites

• I have written a descriptive issue title
• I have verified that I am running the latest version of Fonts
• I have verified if the problem exist in both DEBUG and RELEASE mode
• I have searched open and closed issues to ensure it has not already been reported

Fonts version

3.0.0-alpha.0.6

Other Six Labors packages and versions

Drawing: 3.0.0-alpha.0.6 ImageSharp: 4.0.0-alpha.0.55

Environment (Operating system, version and so on)

Ubuntu 24.04

.NET Framework version

.net 9.0

Description

#475 is fixed, this is another one, that happen with more stuff, still triggered only when adding the Sinhala part to the text

Steps to Reproduce

Repro: https://telras.socolin.fr/repro-infinite-render.zip

dotnet run then it's going to run forever and take all the memory

Images

No response

[JimBobSquarePants]

You need to test against 3.0.0-alpha.0.7

[Socolin]

Ho I missed this version, So main problem fixed, but there is an ArgumentNullException now, maybe the same as #479

Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'collection')
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at SixLabors.Fonts.Tables.TrueType.Glyphs.GlyphVector.DeepClone(GlyphVector src)
   at SixLabors.Fonts.Tables.TrueType.TrueTypeGlyphMetrics.CloneForRendering(TextRun textRun)
   at SixLabors.Fonts.GlyphPositioningCollection.TryUpdate(Font font, GlyphSubstitutionCollection collection)
   at SixLabors.Fonts.TextLayout.DoFontRun(ReadOnlySpan`1 text, Int32 start, IReadOnlyList`1 textRuns, Int32& textRunIndex, Int32& codePointIndex, Int32& bidiRunIndex, Boolean isFallbackRun, Font font, BidiRun[] bidiRuns, Dictionary`2 bidiMap, GlyphSubstitutionCollection substitutions, GlyphPositioningCollection positionings)
   at SixLabors.Fonts.TextLayout.ProcessText(ReadOnlySpan`1 text, TextOptions options)
   at SixLabors.Fonts.TextLayout.GenerateLayout(ReadOnlySpan`1 text, TextOptions options)
   at SixLabors.Fonts.Rendering.TextRenderer.RenderText(ReadOnlySpan`1 text, TextOptions options)
   at SixLabors.Fonts.Rendering.TextRenderer.RenderText(String text, TextOptions options)
   at SixLabors.ImageSharp.Drawing.Processing.Processors.Text.DrawTextProcessor`1.BeforeImageApply()
   at SixLabors.ImageSharp.Processing.Processors.ImageProcessor`1.SixLabors.ImageSharp.Processing.Processors.IImageProcessor<TPixel>.Execute()
   at SixLabors.ImageSharp.Processing.DefaultImageProcessorContext`1.ApplyProcessor(IImageProcessor processor, Rectangle rectangle)
   at SixLabors.ImageSharp.Processing.DefaultImageProcessorContext`1.ApplyProcessor(IImageProcessor processor)
   at SixLabors.ImageSharp.Drawing.Processing.DrawTextExtensions.DrawText(IImageProcessingContext source, DrawingOptions drawingOptions, RichTextOptions textOptions, String text, Brush brush, Pen pen)
   at SixLabors.ImageSharp.Drawing.Processing.DrawTextExtensions.DrawText(IImageProcessingContext source, RichTextOptions textOptions, String text, Brush brush, Pen pen)
   at SixLabors.ImageSharp.Drawing.Processing.DrawTextExtensions.DrawText(IImageProcessingContext source, RichTextOptions textOptions, String text, Color color)
   at TestSinhala.<>c__DisplayClass1_0.<Render>b__1(IImageProcessingContext x) in /home/socolin/Downloads/repro-infinite-render/Sinhala.cs:line 131
   at SixLabors.ImageSharp.Processing.ProcessingExtensions.Mutate[TPixel](Image`1 source, Configuration configuration, Action`1 operation)
   at SixLabors.ImageSharp.Processing.ProcessingExtensions.Mutate[TPixel](Image`1 source, Action`1 operation)
   at TestSinhala.Render() in /home/socolin/Downloads/repro-infinite-render/Sinhala.cs:line 131
   at Program.<Main>$(String[] args) in /home/socolin/Downloads/repro-infinite-render/Program.cs:line 1

[Socolin]

Ho no I miss read it, it's not the same as the other story

[JimBobSquarePants]

Is there any possibility that you can reduce those samples?

I loathe adding all those fonts to the repository and that's a massive wall of text.

I strongly recommend this pattern as it helps debug.

Fonts/tests/SixLabors.Fonts.Tests/Issues/Issues_469.cs

Lines 11 to 54 in aefb967

	public void Test_Issue_469()
	{
	StringBuilder stringBuilder = new();
	stringBuilder.AppendLine("Latin: The quick brown fox jumps over the lazy dog.")
	.AppendLine("Cyrillic: Съешь же ещё этих мягких французских булок.")
	.AppendLine("Greek: Ζαφείρι δέξου πάγκαλο, βαθῶν ψυχῆς τὸ σῆμα.")
	.AppendLine("Chinese: 敏捷的棕色狐狸跳过了懒狗")
	.AppendLine("Japanese: いろはにほへと ちりぬるを")
	.AppendLine("Korean: 다람쥐 헌 쳇바퀴에 타고파")
	.AppendLine("Arabic (RTL & Shaping): نص حكيم له سر قاطع وذو شأن عظيم")
	.AppendLine("Hebrew (RTL): דג סקרן שט בים מאוכזב ולפתע מצא חברה")
	.AppendLine("Thai (Complex): เป็นมนุษย์สุดประเสริฐเลิศคุณค่า")
	.AppendLine("Devanagari (Conjuncts): ऋषियों को सताने वाले राक्षसों का अंत हो गया");
	string text = stringBuilder.ToString();
	FontCollection fontCollection = new();
	string arial = fontCollection.Add(TestFonts.Arial).Name;
	string cousine = fontCollection.Add(TestFonts.CousineRegular).Name;
	string hind = fontCollection.Add(TestFonts.HindRegular).Name;
	string nanumGothicCoding = fontCollection.Add(TestFonts.NanumGothicCodingRegular).Name;
	string inconsolata = fontCollection.Add(TestFonts.InconsolataRegular).Name;
	string notoNaskhArabic = fontCollection.Add(TestFonts.NotoNaskhArabicRegular).Name;
	string notoSansJpThin = fontCollection.Add(TestFonts.NotoSansJPRegular).Name;
	string notoSansScThin = fontCollection.Add(TestFonts.NotoSansSCThin).Name;
	string sarabun = fontCollection.Add(TestFonts.SarabunRegular).Name;
	FontFamily mainFontFamily = fontCollection.Get(arial);
	Font mainFont = mainFontFamily.CreateFont(30, FontStyle.Regular);
	TextOptions options = new(mainFont)
	{
	FallbackFontFamilies =
	[
	fontCollection.Get(inconsolata),
	fontCollection.Get(nanumGothicCoding),
	fontCollection.Get(cousine),
	fontCollection.Get(notoSansScThin),
	fontCollection.Get(notoSansJpThin),
	fontCollection.Get(notoNaskhArabic),
	fontCollection.Get(sarabun),
	fontCollection.Get(hind),
	],
	};

[JimBobSquarePants]

@Socolin Figured it out. Issue is a dumb mistake on my part.