fix: Add NULL check to GLFWwindow*#1329
Merged
Reputeless merged 1 commit intoSiv3D:v6_developfrom Jan 10, 2026
Merged
Conversation
Member
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mac版のCTextInput::init()にGLFWwindow*のNULLチェックを追加
Why
Headlessモードでは
SIV3D_ENGINE(Window)->getHandle()がNULLを返してしまい、後続のglfwSetCharCallbackの内部でassertionエラーが発生していました。Linux版のコードではNULLだった場合呼び出しをしていなかったため同様の対応をしました。OpenSiv3D/Siv3D/src/Siv3D-Platform/Linux/Siv3D/TextInput/CTextInput.cpp
Lines 101 to 109 in 8458f3d
How to test
Headlessモードを有効にしたMain.cppでクラッシュしないこと