Skip to content

1.21.1 Axiom with Supplementaries Crashes when changing fluid render opacity #258

@stdcall0

Description

@stdcall0

Mod Name

Axiom

Mod Homepage

https://axiom.moulberry.com/

Minecraft version

1.21.1

Describe the bug

Axiom crashes when changing fluid render opacity with Supplementaries installed

Steps to reproduce

Prepare a 1.21.1 Neoforge client with latest versions of Connector, FFAPI, axiom, Supplementaries (and its dependency Moonlight) installed. Axiom is fabric mod and other are Neoforge mods.

Join a world. Hold L-alt, click the toolbox button, and drag the fluid opacity slider in the toolbox menu.

The game should crash instantly after the opacity value change.

Logs

https://gist.github.com/stdcall0/d3c8d4002c56b0059b279743c329dd59

Additional context

Related issues:

It seems that ForgifiedFabricAPI getFluidSprites method have nullable arguments where in Neoforge API it's not.

Thus, Neoforge mods overriding the method will throw NPE if called with null arguments which FFAPI allows. And Supplementaries is that a case.

Im not familiar with java development and apologize if im mistaken!

Metadata

Metadata

Assignees

Labels

1.21.xTargets Minecraft 1.21bugSomething isn't working

Type

No type

Projects

Status

✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions