[krampfkn] Spack exercise #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implemented additional task 1: Adding the main branch as version. |
|
Implemented additional task 2: Adding build options to spack and CMake. To test the build, you would need to change the repo + branch of the "main" version. I included a patch-file for doing that. I also included the patched file as I chose a very simple/brute option in the code for adhering to the build options (would be even better to change the available interfaces, so we can detect at build time missing build options), but since that is not the main scope, I hope it is ok I did it in a simpler fashion.. |
|
Nice work 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.