Packaged code for PyPI by zipfeljs #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johzip
commented
Nov 15, 2024
johzip
commented
IshaanDesai
reviewed
Dec 7, 2024
Comment on lines
+29
to
+34
| Run the code using python and running the solve function in diffusion2d.py | ||
| it has three parameters with these standard values: | ||
| ``` | ||
| dx = dy = 0.1 | ||
| D = 4. | ||
| ``` |
There was a problem hiding this comment.
These instructions do not describe how to run the packaged code. Commands to run the package would have been helpful here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.