MV3 Support? #28

shuhankuang · 2021-07-13T00:33:06Z

It will support MV3?
thanks.

rushilsrivastava · 2021-07-14T06:28:26Z

At the moment, this will not work with MV3. However, we plan to release this functionality in the near future.

just-jeb · 2021-12-23T09:59:40Z

Any news guys?

obender · 2022-01-23T06:35:05Z

The end of life of V2 reaching in a year and google started to slow down reviews of V2 starting this month....

obender · 2022-01-23T19:25:19Z

@rushilsrivastava Do you need any help implementing the V3 Support?

rushilsrivastava · 2022-01-24T01:31:30Z

Hey guys, thanks for being patient. Let me address a couple of things real quick:

The end of life of V2 reaching in a year and google started to slow down reviews of V2 starting this month....

Yup, MV2 end-of-life (no new updates will be allowed to existing MV2 extensions) is slated for January 2023. I predict that Google will probably end up delaying this, but nevertheless definitely pushes the need for V3 support. While I couldn't find any announcement for slow release of V2 extensions (anecdotally, all our reviews have been approved within 24-hours), as of January 2022, no new extensions with MV2 will be allowed. All this information can be found on Google's Support Page.

@rushilsrivastava Do you need any help implementing the V3 Support?

Here's my roadmap:

Publish new version v1.1.9 with latest bug fixes for Firefox and listeners. This will probably be the last release for 1.x granted there are no new bugs.
Start a new 2.x branch to start working on Manifest V3 changes. Once this is stable, this will become master.

As far as I know, there shouldn't be much work to get this to work in V3 other than reworking how background listeners work. I have no specific timeline to when I will be able to start work on V3, but if others are able to contribute PRs, I can commit to reviewing them and accelerating the roadmap accordingly.

TheSynt4x · 2022-03-15T11:06:05Z

There seems to be a fix for it already, maybe you can use this https://github.com/rubenspgcavalcante/webpack-extension-reloader/pull/139/files @rushilsrivastava?

It's described more here: rubenspgcavalcante/webpack-extension-reloader#125

reorx · 2022-03-16T09:45:32Z

Hey guys, I just submitted a PR to fix this issue. My setup is MacOS Chrome + MV3. Both the extension and background page are working fine with this PR, leaving the content script untested. Feel free to use my fork before the PR merged.

kYem · 2022-07-31T16:37:42Z

I been using reorx fork for now, any plans to merge it in?

sherifmayika · 2022-08-22T03:46:17Z

At the moment, this will not work with MV3. However, we plan to release this functionality in the near future.

come on

tscislo · 2022-11-05T18:06:52Z

I can confirm that PR created by lmichelin in #319 works for MV3 extensions.

rushilsrivastava · 2022-11-17T05:31:38Z

I intend to merge one of the open PRs by the end of November. There seems to be open review comments/concerns on each one of these PRs at the moment

sherifmayika · 2022-11-29T07:22:01Z

I intend to merge one of the open PRs by the end of November. There seems to be open review comments/concerns on each one of these PRs at the moment

There are two ways to resole the problem.

remove polyfill, which is not required in MV3
extend polyfill namespace for browser.runtime to chrome.runtime and browser.tabs to chrome.tabs

reorx · 2023-02-23T16:44:43Z

I adapted @sherifmayika 's advice and finally made my fork work. Please try https://github.com/reorx/webpack-ext-reloader, which should be fully compatible with MV3.

Bnaya · 2023-02-28T08:24:39Z

I adapted @sherifmayika 's advice and finally made my fork work. Please try https://github.com/reorx/webpack-ext-reloader, which should be fully compatible with MV3.

is it published to NPM?

reorx · 2023-02-28T09:33:32Z

Yes it's npm i -D @reorx/webpack-ext-reloader

…

On Tue, Feb 28, 2023 at 4:24 PM Bnaya Peretz ***@***.***> wrote: I adapted @sherifmayika <https://github.com/sherifmayika> 's advice and finally made my fork work. Please try https://github.com/reorx/webpack-ext-reloader, which should be fully compatible with MV3. is it published to NPM? — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDDVEZKFVIAP2OCH64G3DWZWY5FANCNFSM5AH4IDJA> . You are receiving this because you commented.Message ID: ***@***.***>

-- Sincerely, Xiao Meng reorx.com

just-jeb · 2023-03-14T08:14:06Z

@reorx thanks for taking the initiative! Your fork doesn't seem to work for me though, getting an error:
.

Reproduction: https://github.com/just-jeb/angular-chrome-extension/tree/mv3-background-reload

git clone
yarn
yarn watch
Load as unpacked from the dist/angular-chrome-extension folder

reorx · 2023-03-14T08:17:09Z

Can you try the instruction at https://github.com/reorx/webpack-ext-reloader please? The fork may not working properly in the development environment.

…

On Tue, Mar 14, 2023 at 4:14 PM JeB ***@***.***> wrote: @reorx <https://github.com/reorx> thanks for taking the initiative! Your fork doesn't seem to work for me though, getting an error: [image: image] <https://user-images.githubusercontent.com/9823087/224936678-733873bd-9560-4203-bf89-5eeee7bf6553.png> . Reproduction: https://github.com/just-jeb/angular-chrome-extension/tree/mv3-background-reload 1. git clone 2. yarn 3. yarn watch 4. Load as unpacked from the dist/angular-chrome-extension folder — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDDVA6EQ7M363BVMXQRP3W4ASFVANCNFSM5AH4IDJA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Sincerely, Xiao Meng reorx.com

just-jeb · 2023-03-14T09:23:34Z

If by instruction you mean readme then it does follow the instruction.
As for development environment - the whole point of this plugin is to work with development mode, am I missing something?

sherifmayika · 2023-03-14T10:24:16Z

@reorx thanks for taking the initiative! Your fork doesn't seem to work for me though, getting an error: .

Reproduction: https://github.com/just-jeb/angular-chrome-extension/tree/mv3-background-reload

git clone

yarn

yarn watch

Load as unpacked from the dist/angular-chrome-extension folder

-(function(_window) {
-let window: any
-if (_window.document !== undefined) {
-window = _window
-}

+(function() {
+try {window} catch {var window: any;};

just-jeb · 2023-03-14T12:34:11Z

Or

(function(_window) {
let window: any
if (_window?.document !== undefined) {
  window = _window
}

I guess it does the same.

sherifmayika · 2023-03-14T16:21:49Z

Or

(function(_window) {
let window: any
if (_window?.document !== undefined) {
  window = _window
}

I guess it does the same.

try instead of guess

just-jeb · 2023-03-14T16:58:39Z

Thank you for such a useful comment.

sherifmayika · 2023-03-15T04:03:17Z

Or

(function(_window) {
let window: any
if (_window?.document !== undefined) {
  window = _window
}

I guess it does the same.

did you test?

jianjungki · 2023-03-17T15:39:43Z

Actually, I have test for the chrome extension, it shows me like this:

I think it has some problem about manifest v3 so far.

xadamxk · 2023-06-11T01:05:18Z

Any updates regarding manifest v3 support?

reorx · 2023-06-11T02:52:31Z

@xadamxk https://github.com/reorx/webpack-ext-reloader is working properly in my projects, you can have a try

xadamxk · 2023-06-11T02:56:53Z

@reorx

Yup, I got your fork working after commenting here - thank you.

xD33m · 2023-06-11T20:53:17Z

Any hints on how to resolve the "Uncaught TypeError: Cannot read properties of undefined (reading 'document')" issue? @reorx

xadamxk · 2023-06-12T00:01:33Z

Any hints on how to resolve the "Uncaught TypeError: Cannot read properties of undefined (reading 'document')" issue? @reorx

It's broken and is not being maintained, use this fork instead: https://github.com/reorx/webpack-ext-reloader

rushilsrivastava · 2023-06-12T00:03:54Z

Any hints on how to resolve the "Uncaught TypeError: Cannot read properties of undefined (reading 'document')" issue? @reorx

It's broken and is not being maintained, use this fork instead: https://github.com/reorx/webpack-ext-reloader

There are 3 open PRs for Manifest V3, each has there own issues. I'll see if I can clean them up soon, but this repo is being maintained for V2.

vialoh · 2023-09-28T20:49:53Z

#386 has MV3 support and will be included in the next release (1.1.10).

just-jeb · 2023-11-15T11:56:35Z

Well, I still get this when update to 1.1.10.

vialoh · 2023-11-15T12:00:22Z

Well, I still get this when update to 1.1.10.

Are you sure that's from webpack-ext-reloader? Doesn't quite look like the error I remember seeing before.

just-jeb · 2023-11-15T14:25:13Z

It comes from the code that is generated by webpack-ext-reloader (as you can see from the screenshot). I assume it pops up because window does not exist in service workers. I mean there is a fallback for { browser: null } but seems like the browser will throw this error upon any use of window in the service worker.
And it seems to result in service worker not working at all.

vialoh · 2023-11-15T15:26:23Z

And it seems to result in service worker not working at all.

We're using this in a MV3 service worker without issue (aside from a separate library causing issues in the SW), which is why your comment doesn't make sense to me.

I will look further into this today.

reorx · 2024-01-04T07:45:43Z

To all who are concerned about this project, I have updated @reorx/webpack-ext-reloader to version 1.6.0, which addresses a persistent issue where the plugin continually raised errors, significantly disrupting the development experience. The errors in question were primarily the following:

Uncaught (in promise) Error: Could not establish connection. Receiving end does not exist.: This error occurred when the plugin's code attempted to send a message to a tab that did not have a message listener. It has been resolved by adding a .catch statement after the .sendMessage call.
WebSocket is already in CLOSING or CLOSED state: This error commonly appeared after the extension reloaded, when trying to send reload results to a server that was either down or when the socket instance had become outdated. This has been corrected by adding a state check before invoking socket.send.
Websocket HTTP Authentication failed; no valid credentials available: This error surfaced if the webpack process was terminated, as the plugin would then repeatedly attempt to reconnect to the server. It was challenging due to its origin in the 'new WebSocket', which made it impossible to prevent the error from displaying in the console. The fix involved implementing an HTTP server on the same port and using a fetch request to this server as a reconnect attempt.

Overall, @reorx/webpack-ext-reloader is now more robust against errors. You can confidently assume that any errors appearing in chrome://extensions are worth investigating without having to manually clear them out repeatedly.

Additional quality-of-life improvements include:

A clear distinction between changes made to the background, content scripts, and extension pages, ensuring that only the relevant tabs are refreshed. For example, the extension itself will not reload unless changes are made to the background, and side panels remain open after making non-background updates.
To prevent Chrome from terminating an inactive service worker, content scripts and extension pages now send periodic ping/pong messages to the background. This replaces the previous workaround of having to keep the developer tools open for the background page to keep it alive. Therefore, if your extension has any content scripts or extension pages running, it will automatically reload without needing to keep the developer tools open.

rushilsrivastava · 2024-01-04T08:08:20Z

@reorx Can you open a PR with your changes?

CC @vialoh

reorx · 2024-01-04T08:15:32Z

I would like to, but I'm afraid I don't have time to achieve this at the moment. I'm busy with my own projects, and these changes are being made while I am actively developing my extensions. Since the code has changed significantly from the original version, it requires a lot of effort to create a proper PR. Maybe I can get to it sometime later.

…

On Jan 4, 2024 at 16:08:32, Rushil Srivastava ***@***.***> wrote: @reorx <https://github.com/reorx> Can you open a PR with your changes? CC @vialoh <https://github.com/vialoh> — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDDVGQTEDWFVVOCAQ7NYLYMZPQBAVCNFSM5AH4IDJKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBXGY3DONRXGAZA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rushilsrivastava added priority: medium The priority of this issue or PR is medium. type: enhancement New feature or code enhancement. labels Jul 14, 2021

just-jeb mentioned this issue Dec 24, 2021

Update to MV3 just-jeb/angular-chrome-extension#12

Open

reorx mentioned this issue Mar 16, 2022

determine background or extension page by this #220

Closed

2 tasks

Rhilip mentioned this issue Apr 4, 2022

Webpack 5 support? adambullmer/vue-cli-plugin-browser-extension#126

Open

neelkarma mentioned this issue Jun 1, 2022

Manifest version 2 is deprecated ansh/jiffyreader.com#68

Closed

abhijithvijayan mentioned this issue Jun 12, 2022

[Migration] support for Manifest v3 abhijithvijayan/web-extension-starter#66

Open

lmichelin mentioned this issue Aug 15, 2022

add compatibility with manifest V3 #319

Merged

2 tasks

vialoh closed this as completed Sep 28, 2023

MV3 Support? #28

MV3 Support? #28

Comments

shuhankuang commented Jul 13, 2021

rushilsrivastava commented Jul 14, 2021

just-jeb commented Dec 23, 2021

obender commented Jan 23, 2022

obender commented Jan 23, 2022

rushilsrivastava commented Jan 24, 2022

TheSynt4x commented Mar 15, 2022 • edited Loading

reorx commented Mar 16, 2022

kYem commented Jul 31, 2022

sherifmayika commented Aug 22, 2022 • edited Loading

tscislo commented Nov 5, 2022

rushilsrivastava commented Nov 17, 2022

sherifmayika commented Nov 29, 2022 • edited Loading

reorx commented Feb 23, 2023

Bnaya commented Feb 28, 2023

reorx commented Feb 28, 2023 via email

just-jeb commented Mar 14, 2023

reorx commented Mar 14, 2023 via email

just-jeb commented Mar 14, 2023

sherifmayika commented Mar 14, 2023 • edited Loading

just-jeb commented Mar 14, 2023

sherifmayika commented Mar 14, 2023

just-jeb commented Mar 14, 2023

sherifmayika commented Mar 15, 2023

jianjungki commented Mar 17, 2023

xadamxk commented Jun 11, 2023

reorx commented Jun 11, 2023

xadamxk commented Jun 11, 2023 • edited Loading

xD33m commented Jun 11, 2023

xadamxk commented Jun 12, 2023

rushilsrivastava commented Jun 12, 2023

vialoh commented Sep 28, 2023

just-jeb commented Nov 15, 2023

vialoh commented Nov 15, 2023

just-jeb commented Nov 15, 2023 • edited Loading

vialoh commented Nov 15, 2023

reorx commented Jan 4, 2024

rushilsrivastava commented Jan 4, 2024

reorx commented Jan 4, 2024 via email

TheSynt4x commented Mar 15, 2022 •

edited

Loading

sherifmayika commented Aug 22, 2022 •

edited

Loading

sherifmayika commented Nov 29, 2022 •

edited

Loading

sherifmayika commented Mar 14, 2023 •

edited

Loading

xadamxk commented Jun 11, 2023 •

edited

Loading

just-jeb commented Nov 15, 2023 •

edited

Loading