[3.0] No longer uses closing PHP tags in SMF files #8606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Sesquipedalian
force-pushed
the
3.0/no_closing_php_tags
branch
from
cf8c584 to
10148b4
Compare
jdarwood007
approved these changes
Apr 25, 2025
Member
jdarwood007
left a comment
jdarwood007
left a comment
There was a problem hiding this comment.
Given our move to supporting more hooks, this is becoming less of an issue all the time. We still need to do good testing with package manager related actions, as I worry we bust something that makes upgrading and downgrading impossible. But with all the changes we have prepared, hopefully none arise.
This was referenced Apr 28, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7804
Aside from removing the tags themselves, there have also been changes to the SMF\Config, SMF\ErrorHandler, SMF\PackageManager\PackageManager, SMF\Tasks\UpdateUnicode, and SMF\Security classes, as well as changes to ./other/update_timezones.php, .editor_config, and .php-cs-fixer.dist.php in order to support this.