-
Notifications
You must be signed in to change notification settings - Fork 265
Installer and upgrader rewrite #8093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer and upgrader rewrite #8093
Conversation
5dba66b to
2a8c9c9
Compare
|
A lot is incoming, it's my initial work I started to write the installer logic. You should be able to get through an install. But the base logic should get it going for an upgrader and converter logic. |
|
I've also added some task notes based on what I was thinking, please amend or adjust. |
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Co-authored-by: John Rayes <live627@gmail.com>
18e7abe to
a8ef0db
Compare
|
Please remember not to force-push to a shared branch, @jdarwood007. I was able to reconcile the differences in my local repository fairly easily this time, but another time I might not be so lucky. |
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Co-authored-by: John Rayes <live627@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
|
@Sesquipedalian Its being called in the Migration/v2_1/BoardDescriptions What is the optimal call here to put the best effort that SMF can do to safely startup the User::$me object? Keeping in mind we may be coming from a env in which it may not be able to startup things. |
This seems to call ok. |
This would be better: Also, is it indeed the intention here to load a guest user? Because that's what loading user 0 does. |
|
Moved to Alpha 4 as per the internal roadmap. |
|
Due to of a lot of ugliness and misery involved in trying to resolve conflicts, and due to @jdarwood007 informing me that he has limited time to work on it for the next while, I've decided to close this PR and reimplement this code in a new one. The fundamental logic is all there now thanks to @jdarwood007's work, so I will just need to make a few adjustments and finish off the remaining migration step classes, etc., that have not been written yet. |
@jdarwood007, let's use this to work collaboratively on the installer/upgrader rewrite.
Fixes #8261