Skip to content

Conversation

nim65s
Copy link
Member

@nim65s nim65s commented Jan 8, 2025

Hi,

I think we would need some python 3.13 release on PyPI.

While here, I updated a few other things in the release workflows.

Also, the PYPI_TOKEN should be removed in favor of then new "Trusted Publisher Management": https://pypi.org/manage/project/proxsuite/settings/publishing/

@fabinsch fabinsch force-pushed the devel branch 2 times, most recently from 706bc10 to 898270b Compare January 10, 2025 15:01
@fabinsch
Copy link
Collaborator

Hi @nim65s ,
thanks for these updates on Pypi. The failing checks are due to setup-miniconda and should be solved by this commit in another PR.
So I think once the other is merged, we can rebase this here and it should be good.

@jcarpent
Copy link
Member

@nim65s You can now rebase your branch ;)

Copy link
Collaborator

@fabinsch fabinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would say we can also include PyPy 3.10 and we can remove the lines related to PYPI_TOKEN in both release-linux.yml and release-osx-win.yml as I have created a Trusted Publisher on pypi.

Copy link
Collaborator

@fabinsch fabinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge now. Afterward, we will proceed to a new release of Proxsuite.

@fabinsch fabinsch merged commit e42a72b into Simple-Robotics:devel Jan 21, 2025
81 of 84 checks passed
@nim65s nim65s deleted the releases branch February 10, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants