Update target SDK 35, AGP to 8.11, publish-to-s3 to 0.10 and fixed issues with dark mode #251
Conversation
…rk mode compatibility and edge-to-edge support
There was a problem hiding this comment.
I only have superficial suggestions for these changes. They are not required merge though. Rather than leaving a comment on every reference to background_primary, created a pull request targeting the mzorz/target-sdk-35-and-better-dark-mode branch (#252). Feel free to apply any of my suggestions and merge that pull request into this one or merge these changes as is.
| <style name="BaseBottomSheetDialog" parent="Theme.MaterialComponents.DayNight.BottomSheetDialog"> | ||
| <item name="android:colorBackground">@color/background_primary</item> | ||
| <item name="android:windowIsFloating">false</item> | ||
| <item name="bottomSheetStyle">@style/Widget.Design.BottomSheet.Modal</item> | ||
| </style> | ||
|
|
||
| <style name="BottomSheetDialogTheme" parent="BaseBottomSheetDialog"> | ||
| <item name="android:statusBarColor">@android:color/transparent</item> | ||
| </style> | ||
|
|
There was a problem hiding this comment.
| <style name="BaseBottomSheetDialog" parent="Theme.MaterialComponents.DayNight.BottomSheetDialog"> | |
| <item name="android:colorBackground">@color/background_primary</item> | |
| <item name="android:windowIsFloating">false</item> | |
| <item name="bottomSheetStyle">@style/Widget.Design.BottomSheet.Modal</item> | |
| </style> | |
| <style name="BottomSheetDialogTheme" parent="BaseBottomSheetDialog"> | |
| <item name="android:statusBarColor">@android:color/transparent</item> | |
| </style> |
Since the BaseBottomSheetDialog and BottomSheetDialogTheme styles are exactly the same for both values/styles.xml and values-night/styles.xml, we can delete them in values-night/styles.xml. It doesn't hurt to leave keep them though. It's just a suggestion in case we want to add only the differences between dark and light styles in values-night/styles.xml.
There was a problem hiding this comment.
perfect, addressed in 4066d5a (can't apply an "outdated suggestion" since the branch moved)
…ed they work
Co-authored-by: Tyler Heck <theck13@users.noreply.github.com>
Co-authored-by: Tyler Heck <theck13@users.noreply.github.com>
Co-authored-by: Tyler Heck <theck13@users.noreply.github.com>
There was a problem hiding this comment.
Tested by @Twinsen81 here Automattic/simplenote-android#1743 (review) 👍
Keeping the simperium library up to date, plus addressing this issue Automattic/simplenote-android#1741 for which we needed to make updates to the underlying auth activities.
Login:
Sign up:
To test