Tests: Allow running async/await in test files #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have previously not been able to use `async/await` in our test files. This can lead to particularly deep nesting or callback-passing when we are trying to sequence events for the purpose of the test. In this change we're adding the `babel-polyfill` to allow us to use those constructs and _linearize_ the async flows.
belcherj
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have previously not been able to use
async/awaitin our test files.This can lead to particularly deep nesting or callback-passing when we
are trying to sequence events for the purpose of the test.
In this change we're adding the
babel-polyfillto allow us to usethose constructs and linearize the async flows.
Testing
Since this only impacts tests, just run
npm testApart from that it's indeterminate if the patch was successful or not.