-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More docs about extending #197
More docs about extending #197
Conversation
Can you also take a look at JuliaWeb/Hyperscript.jl#43 ? Would be sad to leave the cool package unmaintained 😢 |
docs/src/extending.md
Outdated
if i_want_to_use_it | ||
# TODO: should I create a new session myself? | ||
session = Session() | ||
return MyConnection(session) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to create a session here, this will get created automatically! A connection is not in control of a session, instead a Session creates a connection to communicate.
Thank you! : )
edit: you do get the Session in |
Hey! Did I understand the extension system correctly? I made updates to the docs with the things I learned, but please correct the mistakes
Questions:
Session
object?JSServe.FrontendConnection
? To the same WebSocket? Or do you create a newJSServe.FrontendConnection
for each client?JSServe.FrontendConnection
, shouldBase.write(::MyConnection
write to all connected clients?