Repository navigation
Do not let CleanRoot failures break startup - #1117
Merged
Merged
Conversation
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirectoryCleaner.CleanRootruns from theDirectoryFinderstatic constructor and had no protection around the per-directory clean. Any exception there surfaced as aTypeInitializationExceptionand failed every test in the run.This can happen when two test processes start at the same time and both try to clean the same stale directory: one removes the directory while the other is still deleting files, and
File.DeletethrowsDirectoryNotFoundException.Each per-directory clean is now wrapped in a try/catch that logs when verbose and moves on, matching what
CleanInstanceRootalready does.