Skip to content

fix case sensitivity for immutable header check #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Dec 19, 2025
Merged

fix case sensitivity for immutable header check #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Delta/DeltaExtensions_Shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ static bool IsImmutableCache(this HttpResponse response)
continue;
}

if (header.Contains("immutable"))
if (header.Contains("immutable", StringComparison.OrdinalIgnoreCase))
{
return true;
}
Expand Down
27 changes: 27 additions & 0 deletions src/DeltaTests/MiddlewareTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,33 @@
[TestFixture]
public class MiddlewareTests
{
[TestCase("immutable")]
[TestCase("IMMUTABLE")]
[TestCase("Immutable")]
[TestCase("public, max-age=31536000, IMMUTABLE")]
public async Task ImmutableCacheControlCaseInsensitive(string cacheControlValue)
{
Recording.Start();
var context = new DefaultHttpContext();
var request = context.Request;
var response = context.Response;

request.Path = "/path";
request.Method = "GET";
response.Headers.CacheControl = cacheControlValue;

var notModified = await DeltaExtensions.HandleRequest(
context,
new RecordingLogger(),
null,
_ => Task.FromResult("rowVersion"),
null,
LogLevel.Information);

IsFalse(notModified);
That(response.Headers["Delta-No304"].ToString(), Does.Contain("immutable"));
}

[Test]
public async Task Combinations([Values] bool suffixFunc, [Values] bool nullSuffixFunc, [Values] bool get, [Values] bool ifNoneMatch, [Values] bool sameIfNoneMatch, [Values] bool etag, [Values] bool executeFunc, [Values] bool trueExecuteFunc, [Values] bool immutable, [Values] bool requestCacheControl)
{
Expand Down