Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize Bibliogram branding #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xanoni
Copy link
Contributor

@xanoni xanoni commented Oct 7, 2021

Changed mentions of "Instagram" to "Bibliogram" across the codebase
to harmonize the code and ensure consistent branding

Changed mentions of "Instagram" to "Bibliogram" across the codebase
to harmonize the code and ensure consistent branding
@miku86
Copy link

miku86 commented Oct 8, 2021

Hey there,

thanks for your efforts!

From the fact, that we want to redirect away from Instagram to a service that does the job, no matter what the replacement is called, I think it makes more sense to name everything instagram.

Especially because the current situation about bibliogram doesn't look that well.

@xanoni
Copy link
Contributor Author

xanoni commented Oct 8, 2021

well, I can do another sed -i ;-) ... I noticed that part of the variables were called "instagramXXX" and part was called "bibliogramXXX", which I found confusing. Also, the text shown in the UI was not consistent. Can we just call it Instagram? Or are there some legal considerations?

For context, I noticed this while putting together the Wikiless PR, where I copied a lot of the Bibliogram code...

#301

I think other sites also have this problem, but I didn't get to all of it.

@xanoni
Copy link
Contributor Author

xanoni commented Oct 8, 2021

Related tickets: #261, #279, #227

@xanoni
Copy link
Contributor Author

xanoni commented Oct 8, 2021

@SimonBrazell do you have any guidance on the branding aspect? Can we use "Instagram", "Wikipedia", "Twitter", etc.? Or should we rather use "Bibliogram", "Wikiless", "Nitter", etc.?

@3nprob
Copy link

3nprob commented Oct 10, 2021

Posted this on another issue but to bring it in here:

As a both user and developer, it's obviously better with proxied_service_name rather than proxy_software_name. Several proxies are interchangeable (YT for example has several)

On the other hand, doing that may make PR a target for legal threats and harassment. See e.g. https://www.techspot.com/news/91650-facebook-bans-sends-cease-desist-letter-developer-unfollow.html

(Maybe FB have no grounds there but it's murky enough to want to avoid, unless the maintainer is willing to pick that fight)

In light of that, the risk-adverse thing to do would be to stick with current branding, maybe change reddit even.

@xanoni
Copy link
Contributor Author

xanoni commented Oct 10, 2021

In light of that, the risk-adverse thing to do would be to stick with current branding, maybe change reddit even.

This is what I would have thought (thus this PR, and probably more PRs to come for the other sites), but let's wait if the repo owner has any guidance for us.

@SimonBrazell
Copy link
Owner

SimonBrazell commented Dec 6, 2021

Hi guys, just catching up on the discussion, I'm not against changing the "branding", it does make more sense to name things according to the target service. I originally avoided doing this thinking if I mentioned the services, particularly those of Google that had a say in the extension's release (on chrome webstore) then it would hamper my chances of getting it out there, just didn't want to draw unwanted attention really, similar to what @3nprob describes.

I don't know if that's just me being paranoid though.

@SimonBrazell
Copy link
Owner

Okay so just had a look at the code, so this is just variable name changes? No UI facing changes?

@xanoni
Copy link
Contributor Author

xanoni commented Jan 10, 2022

Okay so just had a look at the code, so this is just variable name changes? No UI facing changes?

I forgot but I think so. I noticed that in some places it was called Instagram in the code and Bibliogram in other places ... I found that a bit confusing because it made it difficult to search for code that is related to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants