Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on parentheses in Resource View search #832

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

andersweinstein
Copy link
Contributor

A RegExp is constructed from the search string when locating matching substrings within search results, in order to highlight the matching parts. Can cause exception if search string contains metacharacters such as parentheses. The EscapeRegExp function copied from javascript regexp docs, it is not built in.

@andersweinstein andersweinstein changed the title Escape RegExp special chars in search string Fix error on parentheses in Resource View search Oct 20, 2021
@rgachuhi rgachuhi merged commit 6eaa22c into master Oct 20, 2021
@rgachuhi rgachuhi deleted the AUTHORING-2347-search-parens branch October 20, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants