Skip to content

Conversation

@vasu-nageshri
Copy link
Contributor

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #586

Copy link
Collaborator

@Sahil-Simform Sahil-Simform left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add a way to disable the semantics if the user wants

// Build the tooltip widget based on whether a custom container is provided.
// Both branches are wrapped with Semantics to improve accessibility by
// marking the tooltip as a live region for screen readers.
final defaultToolTipWidget = widget.container != null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of wrapping semantics twice, wrap it directly on defaultToolTipWidget

@vasu-nageshri vasu-nageshri force-pushed the feat/add-accessibility-support branch 5 times, most recently from af388db to 7b3945f Compare November 27, 2025 09:09
@vasu-nageshri vasu-nageshri force-pushed the feat/add-accessibility-support branch from 7b3945f to b618cac Compare December 10, 2025 06:00
@vasu-nageshri vasu-nageshri force-pushed the feat/add-accessibility-support branch from b618cac to 5accdfa Compare December 10, 2025 06:07
Copy link
Collaborator

@Sahil-Simform Sahil-Simform left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sahil-Simform Sahil-Simform merged commit 4726dbb into master Dec 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility Trouble With ShowcaseView

3 participants