feat: ability to stop all extractors #119

dprevost-LMI · 2024-10-20T01:36:07Z

In a scenario where we want to use the audio player to load several audio messages for different conversations and where navigation between conversations is required only to show one conversation at a time, we need an efficient way to load the audio message but also to cancel nearly everything if we switch to another conversation.

In the above scenario, when navigating away from all those audio players being played or having their waveform extracted, we need to stop them. Otherwise, opening more and more conversations in a short period will bust resources (promises, players, extractors).

This PR provides a new stopAllWaveFormExtractors, which, when called, stops all waveform extraction to free resources for the following conversation that will be loaded. Combined with stopAllPlayers, the new stopPlayersAndExtractors in the useAudioPlayer hook provides a way to stop everything around the audio players to ensure that no more resources are spent on the unmount screen.

The new Stop all players and extractos option:

Other:

Now, the whole audio player HashMap is cleared to stop growing forever without removing keys.
The CountDownLatch was removed since it was not used anywhere.
The delete recording and stop all are hidden under the SIMFORM header click to keep first impression better
The example app image colour space was changed from Gray to RGB, which was causing the tintColor issue not to work
I removed the loading indicator on the stop button and kept it only on the play button. Now it looks better with fewer loading icons spinning everywhere

kuldip-simform

@dprevost-LMI Can you add these new methods in readme docs as well?

example/src/App.tsx

dprevost-LMI · 2024-11-16T13:42:40Z

example/src/assets/icons/play.png

The change cannot be seen since I used a tool to change the space colour from Gray to RBG, this. fixed the tintColor problem on iOS

dprevost-LMI · 2024-11-16T13:56:29Z

Waiting on #123 merge to fix the player button s issue when clicking stop all

dprevost-LMI · 2024-11-18T12:25:41Z

Now waiting on #136 since some promise rejections are missing to thoroughly test the player after stopping everything!

dprevost-LMI · 2024-11-19T11:57:32Z

Rebased and retested on Android and iOS
Note: The error Possible unhandled seen is not caused by this PR but by the stopAllPlayers already existing that I point out and where we made a quick fix in this PR to have the player "auto-fix" when clicking play or seek

Screen.Recording.2024-11-19.at.6.50.32.AM.mov

dprevost-LMI · 2024-11-28T02:03:49Z

@kuldip-simform, when you have a minute, this PR is ready to be approved & merged!

dprevost-LMI · 2024-12-13T00:12:33Z

Hey, I'm just checking if there are still some chances to merge this one; otherwise, I will just close it!

alikazemkhanloo · 2025-01-07T14:18:25Z

Hey, thank you all for your efforts. Is this feature ready to be merged? I guess all the requested changes were done.

dprevost-LMI · 2025-01-13T23:14:17Z

🤔 I have just realized that the below is still missing

@dprevost-LMI Can you add these new methods in readme docs as well?

chore: wrong AudioWaveform import in App.tsx + delete recording button fix: wrong path chore: log error only when not stop by everything fix: missing promise.resolve chore: review `handleStopEverything` and `handleDeleteRecordings` fix: promises resolve too soon because of the stop everything changes fix: all error pass to onError should be an Error instance, not a string fix: move stopEverything in JS + clear all arrays for less leak chore: stop recorder also + remove logPromise chore: remove unneeded changes chore: expose `stopAllWaveFormExtractors` fix: better white delete icon chore: remove delete recodings fix: review array item handling since we clear the arrays chore: fix doc feat: make stopAllWaveFormExtractors work in iOS + remove stopRecording fix: remove everything from the player array to not increase forever chore: small renaming

chore: add missing doc as requested

dprevost-LMI · 2025-01-13T23:34:26Z

@dprevost-LMI Can you add these new methods in readme docs as well?

@kuldip-simform, I have added the missing doc. Can we move forward and merge? Thank you!

dprevost-LMI · 2025-02-07T15:20:48Z

@kuldip-simform @mukesh-simform Are you still open to my contribution, or should I stop trying to reach you guys?

mukesh-simform · 2025-02-07T15:38:39Z

@dprevost-LMI we truly appreciate your contributions—they have been invaluable in enhancing the library, and we absolutely welcome and encourage your input. We've been working on testing other enhancements and planning new releases soon. Please feel free to continue contributing and raising PRs, we'd be happy to review, approve, and merge any improvements or bug fixes!

mukesh-simform · 2025-02-07T15:41:39Z

We will conduct further testing on this open PR and proceed with merging it accordingly. If any changes are required, we will provide feedback. otherwise, it will be included in the upcoming release!

dprevost-LMI · 2025-02-07T16:45:22Z

Thanks for your prompt response! I look forward to your feedback on whether any changes are required before merging!

kuldip-simform · 2025-02-11T05:33:01Z

@dprevost-LMI This looks great. Thank you for adding this feature.
Can you please update this branch with the latest develop branch, as we have just released version 2.1.3, so we can test with all the new features and make sure it is compatible with the latest changes, then we can move forward.

Also If we can add stop all player and extractors button below delete button that would be ideal.

dprevost-LMI · 2025-02-12T13:16:40Z

@kuldip-simform, it is rebased, and by clicking the SIMFORM header, the two options should appear/disappear

Screen.Recording.2025-02-12.at.8.12.39.AM.mov

dprevost-LMI mentioned this pull request Oct 20, 2024

[FEATURE] Stop all extractors to free resources #120

Closed

dprevost-LMI changed the title ~~feat: stop all extractors~~ feat: ability to stop all extractors Oct 20, 2024

kuldip-simform requested changes Oct 22, 2024

View reviewed changes

example/src/App.tsx Outdated Show resolved Hide resolved

example/src/App.tsx Outdated Show resolved Hide resolved

example/src/App.tsx Show resolved Hide resolved

kuldip-simform linked an issue Oct 23, 2024 that may be closed by this pull request

[FEATURE] Stop all extractors to free resources #120

Closed

dprevost-LMI marked this pull request as draft November 9, 2024 12:42

dprevost-LMI force-pushed the allow-to-stop-all-extractors branch 3 times, most recently from 1965941 to 891a7c5 Compare November 9, 2024 13:05

dprevost-LMI mentioned this pull request Nov 9, 2024

fix: stop only the current player and not all players #123

Merged

dprevost-LMI force-pushed the allow-to-stop-all-extractors branch from 97cf9f8 to bb8f68b Compare November 16, 2024 12:31

dprevost-LMI commented Nov 16, 2024

View reviewed changes

dprevost-LMI force-pushed the allow-to-stop-all-extractors branch from 708eeb3 to 1f3a0bf Compare November 18, 2024 12:23

dprevost-LMI force-pushed the allow-to-stop-all-extractors branch from 1f3a0bf to 908217e Compare November 19, 2024 11:41

dprevost-LMI marked this pull request as ready for review November 19, 2024 11:57

dprevost-LMI requested a review from kuldip-simform November 28, 2024 02:20

dprevost-LMI added 8 commits January 13, 2025 18:15

fix: have stop all button pink to work well on white theme

decb7d6

fix: icon not showing on iOS light theme

3abeb01

chore: add easy command to sync iOS pods in example app

786cb1c

chore: in list + hidden stop button + extract wave form on play

9d986b2

chore: fix rebase

20ac983

fix: change color space from Gray to RGB to fix icon tintcolor issue

b556a29

fix: remove loading icon on the stop button, one on the play is enough

28a6877

dprevost-LMI added 6 commits January 13, 2025 18:15

fix: use generic advancedOptionItemTitle style

3d328e3

chore: remove unused styles

936b04f

fix: stop current player on stop all + fix multiple player starting

5f3627f

fix: keep one paused player to fix stopAllplayer breaking other paused

90c962f

fix: paused player when switching since bugs in stopAllplayer are fixed

9b274b2

chore: testing in iOS

294c738

dprevost-LMI force-pushed the allow-to-stop-all-extractors branch from 3affc3c to 201cd50 Compare January 13, 2025 23:31

chore: add missing doc as requested

efc65a3

chore: add missing doc as requested

dprevost-LMI force-pushed the allow-to-stop-all-extractors branch from 201cd50 to efc65a3 Compare January 13, 2025 23:31

kuldip-simform approved these changes Feb 13, 2025

View reviewed changes

mukesh-simform approved these changes Feb 13, 2025

View reviewed changes

mukesh-simform merged commit 33fc88e into SimformSolutionsPvtLtd:develop Feb 13, 2025

feat: ability to stop all extractors #119

feat: ability to stop all extractors #119

Uh oh!

Conversation

dprevost-LMI commented Oct 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kuldip-simform left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dprevost-LMI Nov 16, 2024

Choose a reason for hiding this comment

Uh oh!

dprevost-LMI commented Nov 16, 2024

Uh oh!

dprevost-LMI commented Nov 18, 2024

Uh oh!

dprevost-LMI commented Nov 19, 2024

Uh oh!

dprevost-LMI commented Nov 28, 2024

Uh oh!

dprevost-LMI commented Dec 13, 2024

Uh oh!

alikazemkhanloo commented Jan 7, 2025

Uh oh!

dprevost-LMI commented Jan 13, 2025

Uh oh!

dprevost-LMI commented Jan 13, 2025

Uh oh!

dprevost-LMI commented Feb 7, 2025

Uh oh!

mukesh-simform commented Feb 7, 2025

Uh oh!

mukesh-simform commented Feb 7, 2025

Uh oh!

dprevost-LMI commented Feb 7, 2025

Uh oh!

kuldip-simform commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dprevost-LMI commented Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dprevost-LMI commented Oct 20, 2024 •

edited

Loading

kuldip-simform commented Feb 11, 2025 •

edited

Loading