fix(UNT-T29402): promise leaking and bug fixes #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nilesh-simform
commented
Oct 8, 2024
nilesh-simform
commented
- stop player and set playback speed promise leaking issue
- default function callback for onError prop of waveform
- removed preparePlayerForPath method call on finished playing event called from native
mukesh-simform
approved these changes
Oct 8, 2024
This was
linked to
issues
Oct 8, 2024
dprevost-LMI
reviewed
Oct 8, 2024
| val progress = obj.getInt(Constants.progress) | ||
| val key = obj.getString(Constants.playerKey) | ||
| if (key != null) { | ||
| audioPlayers[key]?.seekToPosition(progress.toLong(), promise) |
Contributor
There was a problem hiding this comment.
Is there any reason to keep forwarding the promise inside the player and pollute the audio player class?
Would it not be safer and cleaner to keep promises inside the module that is doing the bridge between native code and JS?
kuldip-simform
deleted the
fix/UNT-T29402_promise_leaking_and_bug_fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.