Credit Card UI changes #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiyaz-shaikh
force-pushed
the
feature/example_ui_update
branch
from
c317882 to
1229dc3
Compare
| const SizedBox( | ||
| height: 10, | ||
| ), | ||
| const SizedBox(height: 10), | ||
| Expanded( | ||
| child: Padding( | ||
| padding: const EdgeInsets.only(left: 16), |
There was a problem hiding this comment.
Give horizontal padding here and remove padding from line number 326, I guess it will reflect same as expected.
dhvanit-v-simformsolutions
suggested changes
Dec 20, 2022
lib/credit_card_widget.dart
Outdated
| @@ -280,13 +280,16 @@ class _CreditCardWidgetState extends State<CreditCardWidget> | |||
| crossAxisAlignment: CrossAxisAlignment.start, | |||
| children: <Widget>[ | |||
| if (widget.bankName != null && widget.bankName!.isNotEmpty) | |||
There was a problem hiding this comment.
Suggestion : We can make extension for checking null and not empty at same time . Like this,
extension NullableStringExtension on String? {
bool get isNullOrEmpty => this == null || (this?.isEmpty ?? false);
bool get isNotNullAndNotEmpty => this != null && (this?.isNotEmpty ?? false);
}
dhvanit-v-simformsolutions
suggested changes
Dec 20, 2022
faiyaz-shaikh
force-pushed
the
feature/example_ui_update
branch
4 times, most recently
from
14e1f83 to
f728dc4
Compare
DhvanitVaghani
suggested changes
Jan 13, 2023
lib/credit_card_widget.dart
Outdated
| maxLines: 1, | ||
| overflow: TextOverflow.ellipsis, | ||
| style: defaultTextStyle, | ||
| if (widget.bankName?.isNotEmpty == true) |
There was a problem hiding this comment.
You can pass directly condition without comparing it. And nullable variable troubling then add default value false
| child: Padding( | ||
| padding: const EdgeInsets.only(right: 16, top: 16), | ||
| child: Text( | ||
| widget.bankName!, |
faiyaz-shaikh
force-pushed
the
feature/example_ui_update
branch
from
f728dc4 to
b49442a
Compare
DhvanitVaghani
approved these changes
Jan 16, 2023
ShwetaChauhan18
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit Card Example UI changes