🐛 fix: issue #62 #70
Merged
🐛 fix: issue #62 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vatsaltanna
reviewed
May 28, 2022
lib/src/day_view/day_view.dart
Outdated
| @@ -360,6 +349,77 @@ class DayViewState<T> extends State<DayView<T>> { | |||
| } | |||
| } | |||
|
|
|||
| void _updateViewDimensions() { | |||
| _width = widget.width ?? MediaQuery.of(context).size.width; | |||
| assert(_width != 0, "Calendar width can not be 0."); | |||
There was a problem hiding this comment.
should assert post class constructor so it can prevent user from future breaking changes.
lib/src/day_view/day_view.dart
Outdated
| assert(_width != 0, "Calendar width can not be 0."); | ||
|
|
||
| _timeLineWidth = widget.timeLineWidth ?? _width * 0.13; | ||
| assert(_timeLineWidth != 0, "Time line width can not be 0."); |
| offset: 5 + widget.verticalLineOffset, | ||
| ); | ||
|
|
||
| assert(_liveTimeIndicatorSettings.height < _hourHeight, |
ParthBaraiya
force-pushed
the
fix/issue-62
branch
from
90383a5 to
a771ae0
Compare
vatsaltanna
reviewed
May 29, 2022
| @@ -31,5 +31,6 @@ class CalendarControllerProvider<T> extends InheritedWidget { | |||
| } | |||
There was a problem hiding this comment.
changelog is update is missing.
ParthBaraiya
force-pushed
the
fix/issue-62
branch
from
a771ae0 to
863ebf7
Compare
ParthBaraiya
force-pushed
the
fix/issue-62
branch
from
863ebf7 to
c5099f5
Compare
vatsaltanna
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override didUpdateWidget method to update parameters on widget change.