Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add settings for WeekView days divider #439

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

salahmak
Copy link

@salahmak salahmak commented Jan 2, 2025

Description

In WeekView, the styling for the Divider between the week days and the week view grid is hard coded (like shown in the screenshot below):
image

So this PR adds a new class WeekDaysDividerSettings to control the styling for that divider, also includes a autoIndent parameter to prevent the divider from taking the entire width and indenting it to start from where the days row starts.

Result with autoIndent set to true (with some styles applied through the new settings):
image

Same result with autoIndent set to false:
image

This PR also removes the useless hardcoded border below the week days:
Before (autoIndent set to True):
image

After:
image

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #374 and #430

@PRBaraiya
Copy link
Collaborator

Hi @salahmak Please solve the conflicts in this PR.

@salahmak
Copy link
Author

salahmak commented Jan 7, 2025

@PRBaraiya Should be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to remove horizontal divder in timeline header and Timline start space
2 participants