Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes issue #426: 🐛 Fix header style icons visibility on min & max dates #429

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: Fixes issue #426: 🐛 Fix header style icons visibility on min & max dates #429

merged 1 commit into from
Jan 6, 2025

Conversation

shubham-jitiya-simform
Copy link
Contributor

@shubham-jitiya-simform shubham-jitiya-simform commented Dec 11, 2024 •
edited
Loading

Description

  • Fixed previous and next icons if end dates are reached (Min and max dates) in header style month, day & weekview.
  • Fixed inconsistent padding issue of right icon in the HeaderStyle.

Preview

  • Disable previous & next icons
Disable buttons flag

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #426

@shubham-jitiya-simform shubham-jitiya-simform marked this pull request as ready for review December 11, 2024 15:17
@shubham-jitiya-simform shubham-jitiya-simform changed the title fix: Fixes issue #426: Fixed header style icons visibility on min & max dates fix: Fixes issue #426: 🐛 Fix header style icons visibility on min & max dates Jan 2, 2025
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_426_disable_buttons_calendar_header branch 6 times, most recently from 157066d to 9da90f7 Compare January 6, 2025 09:21
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_426_disable_buttons_calendar_header branch 5 times, most recently from d74626c to cdb0404 Compare January 6, 2025 11:56
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_426_disable_buttons_calendar_header branch 2 times, most recently from 593b4a2 to 2e994ba Compare January 6, 2025 12:38
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_426_disable_buttons_calendar_header branch from 2e994ba to 0cc4730 Compare January 6, 2025 12:41
PRBaraiya
PRBaraiya approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit d822044 into master Jan 6, 2025
1 check passed
@PRBaraiya PRBaraiya deleted the fix/issue_426_disable_buttons_calendar_header branch January 6, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Show that icon buttons are disabled in CalendarPageHeader
2 participants
@shubham-jitiya-simform @PRBaraiya