🚀 Added support for multiple day events #17
Conversation
Ujas-Majithiya
force-pushed
the
multi-day-event-support
branch
from
cacd42b to
b72e7db
Compare
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # 0.0.3 | |||
There was a problem hiding this comment.
please make this tag as unreleased
lib/src/event_controller.dart
Outdated
| if (_events[i].addEvent(event)) { | ||
| _eventList.add(event); | ||
| assert(event.endDate.difference(event.date).inDays >= 0, | ||
| 'End date must be greater or equal to start date'); |
There was a problem hiding this comment.
grammar mistake : The end date must be greater or equal to the start date
lib/src/event_controller.dart
Outdated
| _rangingEventList.add(event); | ||
| _eventList.add(event); | ||
| } else { | ||
| for (var i = 0; i < _events.length; i++) { |
There was a problem hiding this comment.
can we use for in loop here?
lib/src/event_controller.dart
Outdated
| _eventList.add(event); | ||
| } else { | ||
| for (var i = 0; i < _events.length; i++) { | ||
| if (_events[i].year == event.date.year) { |
There was a problem hiding this comment.
two if condition can be handled with && operator.
lib/src/event_controller.dart
Outdated
| @@ -103,6 +113,37 @@ class EventController<T> extends ChangeNotifier { | |||
| } | |||
| } | |||
|
|
|||
| for (var i = 0; i < _rangingEventList.length; i++) { | |||
There was a problem hiding this comment.
can we use for in loop here ?
lib/src/event_controller.dart
Outdated
| @@ -103,6 +113,37 @@ class EventController<T> extends ChangeNotifier { | |||
| } | |||
| } | |||
|
|
|||
| for (var i = 0; i < _rangingEventList.length; i++) { | |||
| final days = <DateTime>[]; | |||
| for (var d = 0; | |||
There was a problem hiding this comment.
can we use for in loop here ?
There was a problem hiding this comment.
variable names in not proper
lib/src/event_controller.dart
Outdated
| .difference(_rangingEventList[i].date) | ||
| .inDays; | ||
| k++) { | ||
| if (days[k].year == date.year) { |
There was a problem hiding this comment.
multiple if conditions can be handled with && operator
lib/src/event_controller.dart
Outdated
| } | ||
|
|
||
| if (_rangingEventList[i].date.isBefore(_rangingEventList[i].endDate)) { | ||
| for (var k = 0; |
There was a problem hiding this comment.
can we use for in loop here ?
Ujas-Majithiya
force-pushed
the
multi-day-event-support
branch
11 times, most recently
from
5d285bc to
758d114
Compare
README.md
Outdated
| event: "Event 1", | ||
| ); | ||
|
|
||
| CalendarControllerProvider.of(context).controller.remove(event); |
There was a problem hiding this comment.
This should be add now remove.
Ujas-Majithiya
force-pushed
the
multi-day-event-support
branch
from
758d114 to
6466ec0
Compare
Ujas-Majithiya
force-pushed
the
multi-day-event-support
branch
from
6466ec0 to
c790965
Compare
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # unreleased | |||
There was a problem hiding this comment.
this should be like # [0.0.3] - October 11, 2021 [Unreleased]
lib/src/event_controller.dart
Outdated
| if (_events[i].year == event.date.year) { | ||
| if (_events[i].addEvent(event)) { | ||
| assert(event.endDate.difference(event.date).inDays >= 0, | ||
| 'The end date must be greater or equal to start date'); |
There was a problem hiding this comment.
The end date must be greater or equal to the start date
No description provided.