📝 added analysis options and refactor code to follow analysis options. #14
Conversation
ParthBaraiya
assigned DevarshRanpara and vatsaltanna-simformsolutions and unassigned DevarshRanpara and vatsaltanna-simformsolutions
ParthBaraiya
requested review from
DevarshRanpara and
vatsaltanna-simformsolutions
There was a problem hiding this comment.
@ParthBaraiya I have seen, we removed MainAxisSize, MainAxisAlignment and CrossAxisAlignment,
Could you let me know why we made those changes?
| @@ -104,15 +105,11 @@ class InternalWeekViewPage<T> extends StatelessWidget { | |||
| height: height + weekTitleHeight, | |||
| width: width, | |||
| child: Column( | |||
| mainAxisSize: MainAxisSize.max, | |||
| mainAxisAlignment: MainAxisAlignment.start, | |||
There was a problem hiding this comment.
Why we removed MainAxisSize and MainAxisAlignment?
There was a problem hiding this comment.
Values we provided as arguments are default values for Column. So whether we provide it or not doesn't matter.
| crossAxisAlignment: CrossAxisAlignment.end, | ||
| children: [ | ||
| SizedBox( | ||
| width: width, | ||
| child: Row( | ||
| mainAxisSize: MainAxisSize.max, | ||
| mainAxisAlignment: MainAxisAlignment.start, | ||
| crossAxisAlignment: CrossAxisAlignment.start, |
There was a problem hiding this comment.
Why we removed MainAxisSize and MainAxisAlignment?
There was a problem hiding this comment.
Values we provided as arguments are default values for Row. So whether we provide it or not doesn't matter.
| @@ -116,9 +116,6 @@ class FilledCell<T> extends StatelessWidget { | |||
| return Container( | |||
| color: backgroundColor, | |||
| child: Column( | |||
| mainAxisAlignment: MainAxisAlignment.start, | |||
| crossAxisAlignment: CrossAxisAlignment.center, | |||
| mainAxisSize: MainAxisSize.max, | |||
| children: [ | |||
There was a problem hiding this comment.
Why we removed MainAxisSize, MainAxisAlignment and CrossAxisAlignment?
There was a problem hiding this comment.
Values we provided as arguments are default values for Column. So whether we provide it or not doesn't matter.
| @@ -149,8 +146,6 @@ class FilledCell<T> extends StatelessWidget { | |||
| physics: BouncingScrollPhysics(), | |||
| child: Column( | |||
| mainAxisSize: MainAxisSize.min, | |||
| crossAxisAlignment: CrossAxisAlignment.center, | |||
| mainAxisAlignment: MainAxisAlignment.start, | |||
There was a problem hiding this comment.
Why we removed MainAxisAlignment and CrossAxisAlignment?
There was a problem hiding this comment.
Values we provided as arguments are default values for Column. So whether we provide it or not doesn't matter.
| @@ -166,7 +161,6 @@ class FilledCell<T> extends StatelessWidget { | |||
| padding: const EdgeInsets.all(2.0), | |||
| alignment: Alignment.center, | |||
| child: Row( | |||
| mainAxisSize: MainAxisSize.max, | |||
There was a problem hiding this comment.
Values we provided as arguments are default values for Row. So whether we provide it or not doesn't matter.
No description provided.