Merge pull request #442 from SimformSolutionsPvtLtd/fix/header_icon_c…

…olor fix: 🔨 Fix header icon color issue
SimformSolutionsPvtLtd · Jan 2, 2025 · 912bd73 · 912bd73
2 parents 836953e + 74e90ca
commit 912bd73
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - Fixes right icon always shows default icon in `CalendarPageHeader` when providing custom icon. [#432](https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/issues/432)
 - Adds `hideDaysNotInMonth` argument in `cellBuilder` in readme. [#433](https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/issues/433)
 - Fixes `titleColor` of date for `hideDaysNotInMonth: false`.
+- Fixes issue of header icon `color` property in `IconDataConfig`.
 
 # [1.3.0 - 12 Nov 2024](https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/tree/1.3.0)
 

diff --git a/lib/src/components/headers/calendar_page_header.dart b/lib/src/components/headers/calendar_page_header.dart
@@ -83,8 +83,7 @@ class CalendarPageHeader extends StatelessWidget {
     this.secondaryDate,
     @Deprecated("Use HeaderStyle.decoration to provide background")
     this.backgroundColor = Constants.headerBackground,
-    @Deprecated("Use HeaderStyle to provide icon color")
-    this.iconColor = Constants.black,
+    @Deprecated("Use HeaderStyle to provide icon color") this.iconColor,
     this.headerStyle = const HeaderStyle(),
   })  : assert(
             titleBuilder != null || dateStringBuilder != null,

diff --git a/lib/src/components/headers/day_page_header.dart b/lib/src/components/headers/day_page_header.dart
@@ -20,8 +20,7 @@ class DayPageHeader extends CalendarPageHeader {
     VoidCallback? onPreviousDay,
     StringProvider? dateStringBuilder,
     required DateTime date,
-    @Deprecated("Use HeaderStyle to provide icon color")
-    Color iconColor = Constants.black,
+    @Deprecated("Use HeaderStyle to provide icon color") Color? iconColor,
     @Deprecated("Use HeaderStyle to provide background")
     Color backgroundColor = Constants.headerBackground,
     HeaderStyle headerStyle = const HeaderStyle(),

diff --git a/lib/src/components/headers/month_page_header.dart b/lib/src/components/headers/month_page_header.dart
@@ -17,8 +17,7 @@ class MonthPageHeader extends CalendarPageHeader {
     VoidCallback? onNextMonth,
     AsyncCallback? onTitleTapped,
     VoidCallback? onPreviousMonth,
-    @Deprecated("Use HeaderStyle to provide icon color")
-    Color iconColor = Constants.black,
+    @Deprecated("Use HeaderStyle to provide icon color") Color? iconColor,
     @Deprecated("Use HeaderStyle to provide background color")
     Color backgroundColor = Constants.headerBackground,
     StringProvider? dateStringBuilder,

diff --git a/lib/src/components/headers/week_page_header.dart b/lib/src/components/headers/week_page_header.dart
@@ -19,8 +19,7 @@ class WeekPageHeader extends CalendarPageHeader {
     VoidCallback? onPreviousDay,
     required DateTime startDate,
     required DateTime endDate,
-    @Deprecated("Use HeaderStyle to provide icon color")
-    Color iconColor = Constants.black,
+    @Deprecated("Use HeaderStyle to provide icon color") Color? iconColor,
     @Deprecated("Use HeaderStyle to provide background color")
     Color backgroundColor = Constants.headerBackground,
     StringProvider? headerStringBuilder,