Skip to content

fix: Prevent PlayerController init on unsupported platforms#464

Open
Namaneo wants to merge 1 commit into
SimformSolutionsPvtLtd:mainfrom
Namaneo:gate-player
Open

fix: Prevent PlayerController init on unsupported platforms#464
Namaneo wants to merge 1 commit into
SimformSolutionsPvtLtd:mainfrom
Namaneo:gate-player

Conversation

@Namaneo

@Namaneo Namaneo commented Jun 26, 2026

Copy link
Copy Markdown

Description

The audio_waveforms package only supports Android and iOS, and playerController.dispose() was called unconditionally, which cause an exception to be raised on unsupported platforms whenever the chat view is disposed. This PR fixes this issue by only initializing a PlayerController when actually supported.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant