Make webpack 4 compatible #98

macisi · 2018-03-02T07:16:01Z

Now the plugin works fine with webpack@4.0.0 and html-webpack-plugin@3.0.4. 😃

SimenB · 2018-03-03T07:27:10Z

Thanks! I'll make some more tweaks before releasing 3.0.0 🙂

JounQin · 2018-03-06T15:58:58Z

~~Error: Plugin could not be registered at 'html-webpack-plugin-before-html-generation'. on webpack 4.1.0, html-webpack-plugin 3.0.6~~

OK, I found out AddAssetHtmlPlugin should be added after HtmlWebpackPlugin for webpack@4+, and it is better to mention it in README.

SimenB · 2018-03-06T19:17:41Z

Oh, I didn't know that! Makes sense though. Mind sending a PR specifying that in the readme? 🙂

JounQin · 2018-03-09T07:00:33Z

@SimenB Please review #103 .

SimenB changed the base branch from master to next March 3, 2018 07:19

fix: make webpack 4 compatible

2e44fa0

SimenB force-pushed the master branch from f0fddce to 2e44fa0 Compare March 3, 2018 07:21

SimenB merged commit 2911f51 into SimenB:next Mar 3, 2018

SimenB pushed a commit that referenced this pull request Sep 15, 2018

fix: make webpack 4 compatible (#98)

1d88472

SimenB pushed a commit that referenced this pull request Sep 15, 2018

fix: make webpack 4 compatible (#98)

5162ecf

Provide feedback