fix(network_monitor): Delete previously allocated events in contiki #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
requested review from
Thomasdjb,
lmolina,
silabs-aydogane and
silabs-peterb
rzr
added a commit
to rzr/UnifySDK
that referenced
this pull request
Apr 30, 2025
This prevent potential access to invalid address, typically after a deletion. This change should be forwarded upstream, once contiki dependency is managed in modular way (using ref to upstream not code dump). Relate-to: SiliconLabsSoftware/z-wave-protocol-controller#94 Relate-to: UIC-3659 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#17 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
1 task
rzr
added a commit
to rzr/UnifySDK
that referenced
this pull request
Apr 30, 2025
This prevent potential access to invalid address, typically after a deletion. This change should be forwarded upstream, once contiki dependency is managed in modular way (using ref to upstream not code dump). Origin: SiliconLabs#52 Relate-to: SiliconLabsSoftware/z-wave-protocol-controller#94 Relate-to: UIC-3659 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#17 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#40 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Thomasdjb
approved these changes
Apr 30, 2025
Now events are forwarded to C++ handler functions by reference, instead of pointers, it is safer to avoid potential use on null pointers. So now on, previously allocated (in post) user data are freed just after handling them. I am assuming that once events are posted, the owner is the contiki event loop, which should free events data once consumed by handler. In other works contiki is managing the lifecyle of user data. Note that once event if processed, the address still remain in contiki queue but no more referenced since the queue pointer is moving to the next one. A later change for contiki can explicitly set the consumed pointer to null in consumed queue cell. Relate-to: UIC-3659 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#17 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
force-pushed
the
zpc/network/review/main
branch
from
41909f2 to
8db135b
Compare
|
Let's merge it since there is no negative feedback after 2 weeks |
Thomasdjb
pushed a commit
to Thomasdjb/z-wave-protocol-controller
that referenced
this pull request
Oct 28, 2025
Now events are forwarded to C++ handler functions by reference, instead of pointers, it is safer to avoid potential use on null pointers. So now on, previously allocated (in post) user data are freed just after handling them. I am assuming that once events are posted, the owner is the contiki event loop, which should free events data once consumed by handler. In other works contiki is managing the lifecyle of user data. Note that once event if processed, the address still remain in contiki queue but no more referenced since the queue pointer is moving to the next one. A later change for contiki can explicitly set the consumed pointer to null in consumed queue cell. Relate-to: UIC-3659 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#17 Origin: SiliconLabsSoftware#94 Forwarded: SiliconLabsSoftware/z-wave-engine-application-layer#41 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now events are forwarded to C++ handler functions by reference, instead of pointers, it is safer to avoid potential use on null pointers.
So now on, previously allocated (in post) user data are freed just after handling them.
I am assuming that once events are posted, the owner is the contiki event loop, which should free events data once consumed by handler.
In other works contiki is managing the lifecyle of user data.
Note that once event is processed, the address still remain in contiki queue but no more referenced since the queue pointer is moving to the next one.
A later change for contiki can explicitly set the consumed pointer to null in consumed queue cell.
Relate-to: UIC-3659
Relate-to: https://github.com/SiliconLabsSoftware/z-wave-engine-application-layer/issues/17
Change
Checklist