Skip to content

Conversation

@rzr
Copy link
Collaborator

@rzr rzr commented Feb 12, 2025

Change

To be merged after:

Is anything more missing ?

Checklist

@rzr rzr marked this pull request as draft February 12, 2025 18:01
@rzr
Copy link
Collaborator Author

rzr commented Feb 13, 2025

https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 is released

Couple of patches to land before merging and tagging this one

rzr added a commit that referenced this pull request Feb 13, 2025
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr marked this pull request as ready for review February 13, 2025 14:33
rzr added a commit that referenced this pull request Feb 13, 2025
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from 6c277b7 to c6a2e6b Compare February 13, 2025 14:37
rzr added a commit that referenced this pull request Feb 13, 2025
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from c6a2e6b to 3e6e2fc Compare February 13, 2025 14:49
rzr added a commit that referenced this pull request Feb 13, 2025
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from 3e6e2fc to e5a2d31 Compare February 13, 2025 17:28
@rzr
Copy link
Collaborator Author

rzr commented Feb 13, 2025

updated PR with 2 more patches for RC9 for smoktesting, to be merged tomorrow.

rzr added a commit that referenced this pull request Feb 13, 2025
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from e5a2d31 to 5475d61 Compare February 13, 2025 17:48
rzr added 2 commits February 13, 2025 19:42
For some reasons it was using an older annotated tag (RC0)
I didnt investigate much, but I believe it prefer tags in branches (main)
which is a good practice,
If confirmed we can switch back to the default describe
and enforce tags in branches.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from 5475d61 to 4e8133b Compare February 13, 2025 18:43
rzr added a commit that referenced this pull request Feb 14, 2025
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

For the record the whole zpc code can be built using this oneliner:

  time docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main # 17min

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@silabs-peterb
Copy link

I tested this version with an inclusion on my system:

My setup:
Docker under WSL
Controller: brd4205b -> SAPI 7.19
DUT: brd4205b -> Doorlock from 24q4 release
Region: US

Looks good on my side!

@rzr
Copy link
Collaborator Author

rzr commented Feb 14, 2025

Great thank you all for review and time , for the record @silabs-aydogane setup (built on macos)

Controller: brd4205b -> Controller NCP SAPI from 24q4 release
DUT: brd4205b -> Switch on/off from 24q4 release
Region: EU
OS: OSX native (edited)

@rzr rzr merged commit 7411581 into main Feb 14, 2025
1 check passed
rzr added a commit that referenced this pull request Feb 14, 2025
For some reasons it was using an older annotated tag (RC0)
I didnt investigate much, but I believe it prefer tags in branches (main)
which is a good practice,
If confirmed we can switch back to the default describe
and enforce tags in branches.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

For the record the whole zpc code can be built using this oneliner:

  time docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main # 17min

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Feb 18, 2025
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Feb 18, 2025
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Feb 18, 2025
Origin: SiliconLabsSoftware#42
Relate-to: Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 19, 2025
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: #42
Relate-to: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 19, 2025
Origin: #42
Relate-to: Relate-to: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
For some reasons it was using an older annotated tag (RC0)
I didnt investigate much, but I believe it prefer tags in branches (main)
which is a good practice,
If confirmed we can switch back to the default describe
and enforce tags in branches.

Origin: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

For the record the whole zpc code can be built using this oneliner:

  time docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main # 17min

Origin: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
Origin: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
Origin: SiliconLabsSoftware#42
Relate-to: Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
For some reasons it was using an older annotated tag (RC0)
I didnt investigate much, but I believe it prefer tags in branches (main)
which is a good practice,
If confirmed we can switch back to the default describe
and enforce tags in branches.

Origin: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

For the record the whole zpc code can be built using this oneliner:

  time docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main # 17min

Origin: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
Origin: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Apr 16, 2025
Origin: SiliconLabsSoftware#42
Relate-to: Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr deleted the release/review/main branch April 24, 2025 15:48
Thomasdjb pushed a commit to Thomasdjb/z-wave-protocol-controller that referenced this pull request Oct 28, 2025
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Thomasdjb pushed a commit to Thomasdjb/z-wave-protocol-controller that referenced this pull request Oct 28, 2025
Origin: SiliconLabsSoftware#42
Relate-to: Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants