Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csa::master into master #71

Merged
merged 236 commits into from
Oct 25, 2024
Merged

Update csa::master into master #71

merged 236 commits into from
Oct 25, 2024

Conversation

mkardous-silabs
Copy link
Contributor

Description

PR Updates main from csa::master.

arkq and others added 30 commits October 4, 2024 14:44
* Add TC_CCTRL_2_1 to CI

* Add TC_CCTRL_2_2 to CI

* Fix copy-paste typo

* Allow to override test runner YAML options with command line options

* Add TC_CCTRL_2_3 to CI

* Run tests on CI

* Add MCORE.FS to PICS.yaml
The default for the build environment shoudl be in the out dir
since that's already excluded from git. Makes things easier for
people following the documentation for the first time who won't
necessarily change that directory to their preferred location.
…ute (#35903)

* Added a new server-side optional attribute `TCUpdateDeadline` (code 0x09) to the General Commissioning Cluster XML.
* This attribute is a 32-bit unsigned integer (`int32u`) and is marked as non-writable.
* The attribute is defined as provisional with `apiMaturity="provisional"`.
* It includes read access with the privilege set to administer.
* Re-generated using ./scripts/tools/zap_regen_all.py
…control (#35862)

* Add separate listing for device types

* Make unit tests work

* Restyle

* Fixup include

* Fixup include

* Make use of DataModel::Provider when doing device type resolution

* Add clang-tidy comments

* Fix merge error: duplicate declaration

* Fix a few more merge conflict markers

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
* Add missing feature map bit

* Generation
…t ids. (#35920)

Makes it easier to tell what commands are being sent, and what attributes are
being written.
1) For request paths, clearly mark wildcards instead of logging 0.

2) For all paths except command paths, when we have a value (cluster id,
   attribute id, event id) that we can find a string representation for,
   log that string representation.

Command paths are a bit complicated because we have to know whether this is a
request or a response and we don't have that information in MTRCommandPath at
the moment.  Will be done in a followup.
IDs are unsigned; we should not be formatting them with %d, because for
vendor-prefixed ones that might make them look negative.
…s (#35907)

* tv-casting-app fix loading stale binding endpoints from un-needed fabrics

* Fixing style issues

* Addressed comments by sharadb-amazon

* Addressed comments by sharadb-amazon 2

* Addressed comments by sharadb-amazon 3
…command (#35926)

* Use ScheduleLambda() instead of PlatformMgr().ScheduleWork to excute command

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
* Enable MRP in WiFi-PAF commissioning

Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>

* Restyled by clang-format

---------

Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
* [Linux] Matter Linux Water Leak Detector Example

* Update README.md

Remote Echo protocol section

* Update water-leak-detector-app.zap

* Symlinks

* New sym links

* Update README.md

Fix typo

* Create water-leak-detector-app.matter

* Update water-leak-detector-app.matter

Remove last line

* Update README.md

* Update water-leak-detector-app.matter

* Update water-leak-detector-app.zap

* Update water-leak-detector-app.matter

* Update water-leak-detector-app.zap

* Update water-leak-detector-app.matter

* Delete examples/water-leak-detector-app/linux/README.md

* Update targets.py to add WATER_LEAK_DETECTOR

* Update host.py to add WATER_LEAK_DETECTOR

* Update water-leak-detector-app.matter

Fix ThreeLevelAutoEnum

* Update all_targets_linux_x64.txt

Add water-leak-detector
* Added WebRTC Requestor cluster xml file and associated references

* Generated using ./scripts/tools/zap_regen_all.py

* Fixed command descriptions.

* (re)Generated using ./scripts/tools/zap_regen_all.py

* (re)Generated using ./scripts/tools/zap_regen_all.py
…llers to the concrete controller class. (#35943)

These APIs are never used for XPC controllers, and the base class implementation
does not really make sense.
…oncrete. (#35945)

The base class implements these selectors already, and its implementation is
perfectly fine.
* Add a size-display script for binaries.

I am currently looking to investigate sizes of our code given
the CodegenDataModel work, so adding a script that can
display a nice treemap of things received from NM.

It is generally hacked-up to display ok data for matter binaries.
(i.e. it splits emberAf and Matter as separate entities).

It is currently a best-effort.

* Restyled by autopep8

* Restyled by isort

* Support some zoom and better parenting

* Restyled by autopep8

* Update parenting and fix up auto-format

* Fix up call suffixes if they contain namespaces

* Remove debug print, fix up vtable and thunk

* Allow stripping of entire sections - the C section is large and generally not that useful

* Strip C by default

* Undo default strip: we likely should show the full size because C libs are non-trivial in size

---------

Co-authored-by: Restyled.io <commits@restyled.io>
There isn't actually a _cppCommissioner on the base controller, so that
implementation made no sense.  In practice, the XPC and concrete controller just
have different implementations here, and the base should not try to implement
anything.

Also fixes the concrete implementation to avoid a sync dispatch by caching the
value (which should be immutable) during startup and removes the unnecessary
controllerNodeId override from the concrete controller: the base class handles
that backwards compat shim already.
…35947)

MTROperationalCredentialsDelegate always works with a concrete controller.  Make
that explicit.

At that point, asyncGetCommissionerOnMatterQueue can only get called on an
MTRDeviceController from and MTRBaseDevice that was created for an XPC
controller.  Having that just fail out is perfectly reasonable.
…ithout `ember-compatibility-functions.cpp` (#35919)

* Add ability to skip compiling of ember-compatibility-functions

* Fix build and make sure that CI will validate a data-model-enabled build

* Restyle

* Fix compilation

* Restyled by clang-format

* Typo fix

* Fix includes

* Rename method to something that seems a bit clearer

* Fix pwrpc usage to use datamodel interface

* Restyle

* Remove todo

* Update for attribute is list to support not know value

* Update src/app/WriteHandler.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* [Fabric-Bridge] Replace ScheduleWork with ScheduleLambda

* Restyled by whitespace

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
…Time ICDs (#35956)

* Remove optional spec check

* Add static_assert for the slow poll config for SIT ICDs

* Add missing include

* fix restyler error

* fix spacing

* Remove client build flag since it is not used
…round (#35950)

* Make function argument a reference, to avoid passing in struct data around

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
dependabot bot and others added 22 commits October 23, 2024 18:48
Bumps [third_party/openthread/repo](https://github.com/openthread/openthread) from `2aeb8b8` to `287dbfa`.
- [Release notes](https://github.com/openthread/openthread/releases)
- [Commits](openthread/openthread@2aeb8b8...287dbfa)

---
updated-dependencies:
- dependency-name: third_party/openthread/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
… (#36195)

* Add a big endian reader since we seem to potentially want this

* Minor re-arrange

* Fix includes

* Restyled by clang-format

* make some compilers happy

* Update src/lib/support/BufferReader.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…e any cluster leaks (#36215)

* [darwin-framework-tool] ClusterCommandBridge.h does not release the custom argument data, making the leak detector complaining

* [darwin-framework-tool] WriteAttributeCommandBridge.h does not release the custom argument data, making the leak detector complaining
…atformConfig.h by defautl instead of relying on CHIPProjectAppConfig.h (#36178)
…(#35493)

* YAML linter: Add check for manual steps, remove known bad unit tests

* test bad change

* Restyled by isort

* Trying again for CI - checkout had no depth

* testing - I can't repro locally

* ha...removed my test bad test

* more testing...ci is different than local and act

* debugging in ci...fun times

* Restyled by whitespace

* let's just run the one, ya?

* Fix git on the VM

* Actually error though

* Revert "let's just run the one, ya?"

This reverts commit e3c045dd01c65300d04d8d12cba97c4a24bcdb62.

* Remove the added bad step

---------

Co-authored-by: Restyled.io <commits@restyled.io>
* Allow runner's path to be passed

* Bump version
* Use GoogleTest back-end for unit tests running on host

* Setup googletest repo for Android and Tizen builds

* Add missing override
* Added required changes for enabling brd4343a

* Reverted matter_support submodule pointer

* Modified as per review comments
…ert partition (#35821)

* [ESP32] Implement providers which reads unique data from the secure cert partition

Right now secure cert partition stores only device attestation data i.e.
DAC and PAI. This can be extended to store the sort of unique data that
is discriminator, verifier/salt/iteration-count for passcode, and
unique-id for generating rotating id.

- Update the esp_secure_cert_mgr version to 2.5.0

* address review comments
* Remove lwip commited directly to repository

Signed-off-by: Alexander Mazuruk <aalexanderr@gmail.com>

* Re-add lwip as git submodule

Checked out to lastest release as it includes fix applied in Matter
repository as well as some stuff referred to in repository issues.

PBUF_POOL_BUFSIZE does not use sizeof anymore (it is used in one if in
the lwip upstream code). Additionally removed turning off sanity checks
that were necessary due to aforementioned sizeof usage.

Added LwIPLog to Bouffalolab Logging as I couldnt find it defined
anywhere for this platform.

Signed-off-by: Alexander Mazuruk <aalexanderr@gmail.com>

* Remove lwip's mdns from cc32xx

Signed-off-by: Alexander Mazuruk <aalexanderr@gmail.com>

* Adjust lwipopt

Signed-off-by: Alexander Mazuruk <aalexanderr@gmail.com>

---------

Signed-off-by: Alexander Mazuruk <aalexanderr@gmail.com>
Co-authored-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Use TLV-based encoding for ember data buffer.

This saves 2K of flash on some test devices, being much more
efficient in code size compared to using datamodel code.

* Restyled by clang-format

* Restyled by shfmt

* Undo unrelated change

* Add some casts to make android compiler happy

* Updates based on code review

* Added unit tests for min/max int64 values

* Rename PascalString to PascalStringType

* Fix rename

* Restyle

* Add helper methods inside odd sized integers to localize code logic

* Restyled by clang-format

* Fix up negative ranges

* Fixed ranges

* Fix signed max bug and update unit tests

* Make android happy

* Typo fix

* Switch up unit tests

* Update a nullable check to make use of ValueToNullValue

* Add namespace prefix

* Update src/app/codegen-data-model-provider/EmberDataBuffer.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/app/codegen-data-model-provider/EmberDataBuffer.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Correct comments:signed, not unsigned

* Use constructors for the buffer info

* Rename things to EmberAttributeDataBuffer

* Undo submodule updates

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Andrei Litvin <andreilitvin@google.com>
… unit test members (#36223)

* Fix ICD manager and attributes

* Generated files

* zap regen
… 1 by default if wifi is enabled (#36226)

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
…190)

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
Some devices neither have WAN nor eth interface but use a bridge
interface.

Consider bridge interface as Ethernet, so these devices can use bridge
interface.

Co-authored-by: Céleste Cote <celeste.cote@rtone.fr>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
* DRLK-2.1: use correct PICS for prompt test steps

The test case while defining the prompt usage test step, the incorrect PICS has been set PICS_SKIP_SAMPLE_APP instead of
PICS_USER_PROMPT

* Update Test_TC_DRLK_2_1.yaml - restyle changes

---------

Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Added Heat Pump, Solar Power, Battery Storage to matter-devices.xml

* Update after regen_all
…36229)

* Use EmberAttributeDataBuffer for codegen provider _Read

* Fix comments

* Restyled by clang-format

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>
…ax failure and even on success (#36227)

* [chip-tool[darwin-framework-tool] Using a malformed ComplexArgument may result into a leak

* [chip-tool[darwin-framework-tool] Even on success the ComplexArgument may not be cleared properly

---------

Co-authored-by: Andrei Litvin <andy314@gmail.com>
@mkardous-silabs mkardous-silabs requested a review from a team as a code owner October 24, 2024 19:29
@mkardous-silabs
Copy link
Contributor Author

Restyler fail is a fluke - issue will be resolved once the PR is merged into main.

@mkardous-silabs mkardous-silabs merged commit e997be0 into main Oct 25, 2024
11 of 13 checks passed
@mkardous-silabs mkardous-silabs deleted the csa branch October 25, 2024 13:35
@mkardous-silabs mkardous-silabs restored the csa branch October 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.