-
Notifications
You must be signed in to change notification settings - Fork 25
Custom ChipDie #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_2.8-1.5
Are you sure you want to change the base?
Custom ChipDie #431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses an issue where ChipDie was occurring silently, making chips with a dead ChipTask appear as if they were still functioning. The fix introduces custom ChipDie implementation files in the matter_sdk and adds them to the SLC component configurations.
Changes:
- Updated matter_sdk submodule to a new commit containing the custom ChipDie implementation
- Added ChipDie.h header file to the include paths for all platform configurations
- Added ChipDie.cpp source file to the build configuration for all platform configurations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| third_party/matter_sdk | Updates submodule commit to include custom ChipDie implementation |
| slc/component/matter-core-sdk/siwx917.slcc | Adds ChipDie.h and ChipDie.cpp to SiWx917 component configuration |
| slc/component/matter-core-sdk/efr32_wifi.slcc | Adds ChipDie.h and ChipDie.cpp to EFR32 WiFi component configuration |
| slc/component/matter-core-sdk/efr32.slcc | Adds ChipDie.h and ChipDie.cpp to EFR32 component configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
223eb52 to
b974b92
Compare
Sarthak-Shaha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended for the 2.8.0 release or patch1?
rerasool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to align if this is required for 2.8.0 as we are at code freeze. Otherwise hold merging until the branch is open for 2.8.1.
b974b92 to
71f7854
Compare
We do not open branches for 2.8.x, at least we have never done it in the past. I am not extremely familiar with the process, but it seems, rather than freezing every PR until a certain moment, we should put a tag on the commit at code freeze, and then we do not need to have someone actively putting change request every time a PR opens. |
Agreed, this phase could be optimized. At this point, we're only expecting a pointer bump to pick up the final SiSDK/WC build number for completeness (limited to doc and project upgrade metadata change that shouldn’t impact Matter). One option could be to create a temporary 2.8.1 branch to open it up for patch1 and then merge back into 2.8 once the release is out. It may not be worth the overhead though for just a couple of days. I defer to @jmartinez-silabs. |
|
We can wait a few days before merging this. Once release loop is closed |
Issue Link:
n/a
Description of Problem/Feature:
Our ChipDie was happening silently, causing chips with a dead ChipTask to appear as if they were still functioning.
Description of Fix/Solution:
Added custome ChipDie files in matter_sdk, this adds these files to the slc components.
Testing Done:
Build, Flash, ChipDie on : BRD4116A, BR4408A, BRD4338A