Skip to content

Commit

Permalink
Pull request project-chip#551: NoJira: Remove spec commands of respon…
Browse files Browse the repository at this point in the history
…se type and Descriptor

Merge in WMN_TOOLS/matter from bugfix/NoJira_Remove_spec_commands_of_response_type to silabs

Squashed commit of the following:

commit b335d5169632ac6ff4701342adf9a1c3c5bdb7e8
Author: Dennis Jensen <Dennis.Jensen@silabs.com>
Date:   Thu Feb 2 10:43:18 2023 +0100

    NoJira: Remove spec commands of response type and Descriptor

    Changes:
    * Removal of commands which is of Response type rather than an actual
    command.
    * Removed Descriptor in the device type mapping as a map in the Matter
    bridge won't exist without.
  • Loading branch information
unify-automated authored and jmartinez-silabs committed May 25, 2023
1 parent 9c70394 commit e46346d
Show file tree
Hide file tree
Showing 4 changed files with 185 additions and 68 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,15 @@ void TestMatterDeviceScore(nlTestSuite * inSuite, void * aContext)
{
sl_log_debug(LOG_TAG, "Device DoorLock, matter_miss_count: %d, matter_extra: %d", score.matter_miss_count,
score.extra_matter_clusters_count);
// Clusters for DoorLock is [Binding, Descriptor, DoorLock, Identify, TimeSynchronization] we only provide 3
// Clusters for DoorLock is [Binding, Descriptor, DoorLock,
// Identify, TimeSynchronization] we only provide 3
NL_TEST_ASSERT(inSuite, score.matter_miss_count == 2);
// By default FixedLabel and BridgedDeviceBasic is enabled, so we have two extra clusters.
NL_TEST_ASSERT(inSuite, score.extra_matter_clusters_count == 2);
// We have 3 clusters that matches, so we have 3 points
NL_TEST_ASSERT(inSuite, score.required_matter_clusters_count == 3);
// By default FixedLabel and BridgedDeviceBasic is enabled, so we
// have two extra clusters. In addition, we do ignore the Descriptor
// cluster as a spec compliant cluster.
NL_TEST_ASSERT(inSuite, score.extra_matter_clusters_count == 3);
// We have 2 clusters that matches
NL_TEST_ASSERT(inSuite, score.required_matter_clusters_count == 2);
}
}
}
Expand Down
Loading

0 comments on commit e46346d

Please sign in to comment.