GH-24: Fix CC SWITCH_COLOR Duration param #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkljajic
changed the title
nkljajic
added a commit
to nkljajic/UnifySDK
that referenced
this pull request
Nov 29, 2023
Duration can be any value in the range 0x01..0xFD. For reference, see: CC:0000.00.00.11.015 CC:0033.02.05.11.007 Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
nkljajic
force-pushed
the
fix-cc-switch-color-duration-param
branch
from
c3c9d91 to
75be48b
Compare
rzr
requested changes
Nov 30, 2023
applications/zpc/components/zwave_command_classes/assets/ZWave_custom_cmd_classes.xml
Show resolved
Hide resolved
rzr
pushed a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 18, 2024
Duration can be any value in the range 0x01..0xFD. For reference, see: CC:0000.00.00.11.015 CC:0033.02.05.11.007 Signed-off-by: Nenad Kljajic <nkljajic@control4.com> (cherry picked from commit 75be48b) Origin: SiliconLabs#24 Relate-to: Z-Wave-Alliance/zwave_xml#12 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
pushed a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 18, 2024
Duration can be any value in the range 0x01..0xFD. For reference, see: CC:0000.00.00.11.015 CC:0033.02.05.11.007 Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
|
Forwarded-SiliconLabs: task/UIC-3082/phcoval/GH-24/develop We might hold merging until you mark your PR as ready Testing in progress at: https://github.com/rzr/UnifySDK/actions/runs/7572313681/job/20621838443?pr=13 |
rzr
pushed a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 18, 2024
Duration can be any value in the range 0x01..0xFD. For reference, see: CC:0000.00.00.11.015 CC:0033.02.05.11.007 Signed-off-by: Nenad Kljajic <nkljajic@control4.com> (cherry picked from commit 75be48b) Bug-SiliconLabs: UIC-3082 Origin: SiliconLabs#24 Relate-to: Z-Wave-Alliance/zwave_xml#12 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
|
Any objection to merge this downstream at silabs ? |
rzr
pushed a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 23, 2024
Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: https://github.com/nkljajic/UnifySDK/pulls/rzr#GH-24/UIC-3082/phcoval/main Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 23, 2024
Signed-off-by: Philippe Coval <philippe.coval@silabs.com> (cherry picked from commit 7cf96bbd299634ed7bc393eae1d017bf5bf07d21) Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: https://github.com/nkljajic/UnifySDK/pulls/rzr#GH-24/UIC-3082/phcoval/main Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
pushed a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 23, 2024
Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: https://github.com/nkljajic/UnifySDK/pulls/rzr#GH-24/UIC-3082/phcoval/main Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 23, 2024
Signed-off-by: Philippe Coval <philippe.coval@silabs.com> (cherry picked from commit 7cf96bbd299634ed7bc393eae1d017bf5bf07d21) Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: https://github.com/nkljajic/UnifySDK/pulls/rzr#GH-24/UIC-3082/phcoval/main Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
pushed a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 23, 2024
Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: nkljajic#5 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/UnifySDK
that referenced
this pull request
Jan 23, 2024
Signed-off-by: Philippe Coval <philippe.coval@silabs.com> (cherry picked from commit 7cf96bbd299634ed7bc393eae1d017bf5bf07d21) Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: nkljajic#5 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
|
Origin-SiliconLabs: ver_1.5.0-unstable-113-gf25172e927 |
|
Please 1/ check our PRs at: https://github.com/nkljajic/UnifySDK/pulls 2/ mark this change as ready 3/ Test upcoming release in a couple of weeks |
nkljajic
added a commit
to nkljajic/UnifySDK
that referenced
this pull request
Jan 23, 2024
Duration can be any value in the range 0x01..0xFD. For reference, see: CC:0000.00.00.11.015 CC:0033.02.05.11.007 Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
nkljajic
force-pushed
the
fix-cc-switch-color-duration-param
branch
2 times, most recently
from
30512ae to
75be48b
Compare
nkljajic
added a commit
to nkljajic/UnifySDK
that referenced
this pull request
Jan 23, 2024
SiliconLabsGH-14: zpc: Enable testing by default
Duration can be any value in the range 0x01..0xFD. For reference, see: CC:0000.00.00.11.015 CC:0033.02.05.11.007 Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: #5 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Signed-off-by: Philippe Coval <philippe.coval@silabs.com> (cherry picked from commit 7cf96bbd299634ed7bc393eae1d017bf5bf07d21) Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: #5 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
nkljajic
force-pushed
the
fix-cc-switch-color-duration-param
branch
from
12285a0 to
a49973b
Compare
|
Merger PR and rebased to main |
|
ok good It will be in, just expect one more patch from @silabs-borisl |
rzr
approved these changes
Feb 13, 2024
agarwal57
pushed a commit
that referenced
this pull request
Feb 13, 2024
Duration can be any value in the range 0x01..0xFD. For reference, see: CC:0000.00.00.11.015 CC:0033.02.05.11.007 Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
agarwal57
pushed a commit
that referenced
this pull request
Feb 13, 2024
Bug-SiliconLabs: UIC-3082 Relate-to: #24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/GH-24/develop Origin: nkljajic#5 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
CC SWITCH_COLOR Duration can be any value in the range 0x01..0xFD.
For reference, see:
CC:0000.00.00.11.015
CC:0033.02.05.11.007
This fix depends on: https://github.com/Z-Wave-Alliance/zwave_xml/pull/12
Checklist