Repository navigation
Make the Skills library scroller-style test deterministic (#29) - #30
Merged
Merged
Conversation
AppKit resolves NSScroller.preferredScrollerStyle once per process, so in a full run the style was already fixed by an earlier suite and the test's style assertion depended on suite order and the Mac's default. Lay out against the resolved style, check the hosted scroll view uses that same style and that legacy scrollers reserve their width, and keep the strict requested-style check for explicit CONTEXTDADDY_TEST_SCROLLBARS runs. Closes #29 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29.
AppKit resolves
NSScroller.preferredScrollerStyleon the first read in a process and caches it (confirmed with a standalone probe: settingAppleShowScrollBarsafter the first read has no effect). In a full run an earlier suite has already created AppKit views, sorendersLibraryAtSupportedWidthsWithoutLiveDataasserted a style it couldn't control.Change (test only):
NSScrollViewuses that same style (the view's width reservation reads the process style), and with legacy scrollers the clip view is narrower by the scroller width. The existing no-overflow and scroll-to-bottom checks are unchanged.CONTEXTDADDY_TEST_SCROLLBARSruns (use--filter).Verification (local Mac):
swift test --skip DesignSnapshotTests: 5 of 5 full runs pass (26 + 154 tests). Before: 5 of 5 failed (per Flaky test: SkillLibraryViewTests scroller-style expectation depends on suite order #29).--filter rendersLibraryAtSupportedWidthsWithoutLiveDatapasses by default, withCONTEXTDADDY_TEST_SCROLLBARS=Alwaysand with=WhenScrolling.🤖 Generated with Claude Code