Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Agent output not being re-fetched on each agent output dialog opened #8883

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Dec 5, 2024

Dec.4.2024.Video.mp4

Changes πŸ—οΈ

fetchBlockResults should always be triggered when isOutputOpen is true.

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested review from ntindle and kcze December 5, 2024 15:43
@majdyz majdyz requested a review from a team as a code owner December 5, 2024 15:43
Copy link

qodo-merge-pro bot commented Dec 5, 2024

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Data Loading
The removal of blockOutputs.length > 0 check means results will be fetched on every dialog open, even if data was already loaded. Verify this is the intended behavior and doesn't cause unnecessary API calls.

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/s and removed platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 5, 2024
Copy link

netlify bot commented Dec 5, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 1c70c75
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/675282411bb06f00086f7b09

Copy link

netlify bot commented Dec 5, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 1c70c75
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67528241fb911b0008b42b26

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 5, 2024
@majdyz majdyz enabled auto-merge December 6, 2024 04:38
@majdyz majdyz added this pull request to the merge queue Dec 6, 2024
Merged via the queue into dev with commit 9ad9dd9 Dec 6, 2024
19 checks passed
@majdyz majdyz deleted the zamilmajdy/fix-agent-output-not-loaded branch December 6, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/s
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants