Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): Add default secrets #8452

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

aarushik93
Copy link
Contributor

@aarushik93 aarushik93 commented Oct 25, 2024

Background

Add defaults for prod platform for the ones that haven't been moved over to the new credentials provider

Changes 🏗️

Revid, Ideogram, Groq keys.
Resealed other secrets as well, we had an issue with malformed secrets due to kubeseal raw being buggy so I just resealed via file just in case.

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

Configuration Changes 📝

Note

Only for the new autogpt platform, currently in autogpt_platform/

If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.

Examples of such changes might include:

  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@aarushik93 aarushik93 requested a review from a team as a code owner October 25, 2024 16:34
@github-actions github-actions bot added the platform/backend AutoGPT Platform - Back end label Oct 25, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
The PR introduces several new API keys and sensitive credentials (REPLICATE_API_KEY, IDEOGRAM_API_KEY, GROQ_API_KEY, REVID_API_KEY, ANTHROPIC_API_KEY, OPENAI_API_KEY) in the autogpt_platform/infra/helm/autogpt-server/values.prod.yaml file. While these appear to be encrypted, it's crucial to verify that proper encryption and secure storage methods are being used to protect these sensitive values.

⚡ Recommended focus areas for review

Security Concern
New API keys and sensitive information have been added. Ensure these are properly encrypted and securely stored.

@aarushik93 aarushik93 merged commit e990a9d into dev Oct 25, 2024
6 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/add-default-secrets branch October 25, 2024 16:35
aarushik93 added a commit that referenced this pull request Oct 25, 2024
* secrets

* seal secrets

* remove jina

* replicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant