-
Notifications
You must be signed in to change notification settings - Fork 44.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace os with pathlib for ai_config.py #647
replace os with pathlib for ai_config.py #647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the PR more focused:
- My pull request is atomic and focuses on a single change. - NOT TRUE
- I have not snuck in any "extra" small tweaks changes - NOT TRUE
We will be following the standard. You can submit the changes about improving standard compliance (which one? pep8? isort?) separately from this PR. Some of them are already elsewhere e.g. in #590 |
@Back2Basics There are conflicts again due to the merging of other PRs |
Hope this gets updated. Nice change. |
3294fc2
to
6a93537
Compare
…vitas#647) * fix nlp bug * resetting model to electra small * removing model_path from fit_kwargs_by_estimator
Background
Changes
Documentation
Test Plan
PR Quality Checklist