Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace os with pathlib for ai_config.py #647

Conversation

Back2Basics
Copy link

@Back2Basics Back2Basics commented Apr 10, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thouroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

Copy link
Contributor

@nponeccop nponeccop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the PR more focused:

  • My pull request is atomic and focuses on a single change. - NOT TRUE
  • I have not snuck in any "extra" small tweaks changes - NOT TRUE

scripts/ai_config.py Outdated Show resolved Hide resolved
scripts/ai_config.py Outdated Show resolved Hide resolved
scripts/ai_config.py Outdated Show resolved Hide resolved
@nponeccop
Copy link
Contributor

We will be following the standard. You can submit the changes about improving standard compliance (which one? pep8? isort?) separately from this PR. Some of them are already elsewhere e.g. in #590

@nponeccop nponeccop mentioned this pull request Apr 10, 2023
1 task
@nponeccop
Copy link
Contributor

@Back2Basics There are conflicts again due to the merging of other PRs

This was referenced Apr 12, 2023
@p-i-
Copy link
Contributor

p-i- commented Apr 14, 2023

Hope this gets updated. Nice change.

@nponeccop nponeccop mentioned this pull request Apr 14, 2023
1 task
@Back2Basics Back2Basics force-pushed the feature/pathlib_for_ai_config branch from 3294fc2 to 6a93537 Compare April 15, 2023 05:23
@Back2Basics Back2Basics mentioned this pull request Apr 15, 2023
5 tasks
This was referenced Apr 16, 2023
@Back2Basics Back2Basics mentioned this pull request Apr 17, 2023
5 tasks
SquareandCompass pushed a commit to SquareandCompass/Auto-GPT that referenced this pull request Oct 21, 2023
…vitas#647)

* fix nlp bug

* resetting model to electra small

* removing model_path from fit_kwargs_by_estimator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants