Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create cassette submodule #4420

Merged
merged 6 commits into from
May 26, 2023
Merged

Create cassette submodule #4420

merged 6 commits into from
May 26, 2023

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented May 26, 2023 •
edited
Loading

Background

Cassettes are too big, they need their own submodule

Changes

  • Created submodule
  • add ability to update cassettes in ci pipeline

Documentation

Screenshot 2023-05-25 at 6 38 34 PM

Screenshot 2023-05-25 at 6 38 27 PM

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run black . and isort . against my code to ensure it passes our linter.

@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 38 minutes (more than 100, code: "api-deployments-free-per-day").

@waynehamadi waynehamadi marked this pull request as draft May 26, 2023 01:35
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 26, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@codecov
Copy link

codecov bot commented May 26, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6c45fcd) 67.71% compared to head (cfbabea) 67.71%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4420   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files          72       72           
  Lines        3528     3528           
  Branches      557      557           
=======================================
  Hits         2389     2389           
  Misses        955      955           
  Partials      184      184
Impacted Files Coverage Δ
autogpt/llm/utils/__init__.py 73.04% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi force-pushed the create-cassette-submodule branch from 218c07c to 6bea32f Compare May 26, 2023 02:02
@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 11 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 26, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 6 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the create-cassette-submodule branch from a46e13e to 9cd2ba6 Compare May 26, 2023 17:28
@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 4 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 26, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the create-cassette-submodule branch from 9cd2ba6 to 76268af Compare May 26, 2023 17:34
@vercel
Copy link

vercel bot commented May 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 26, 2023 6:58pm

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 26, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

1 similar comment
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

We committed some changes to this branch, please run

git fetch
git rebase origin/create-cassette-submodule

before pushing more changes to the remote.

@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 30 minutes (more than 100, code: "api-deployments-free-per-day").

@waynehamadi waynehamadi force-pushed the create-cassette-submodule branch from bb3289e to ee1ab8a Compare May 26, 2023 17:47
@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 27 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

We committed some changes to this branch, please run

git fetch
git rebase origin/create-cassette-submodule

before pushing more changes to the remote.

@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 20 minutes (more than 100, code: "api-deployments-free-per-day").

@waynehamadi waynehamadi force-pushed the create-cassette-submodule branch from ce3ae3f to ee1ab8a Compare May 26, 2023 18:04
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi marked this pull request as ready for review May 26, 2023 18:05
BaseInfinity and others added 2 commits May 26, 2023 11:07
@BaseInfinity @waynehamadi
gfeat: specify directory of cassettes and automatically load them dep…
b3bfb98 
…ending on module

fix: formatting for linter

test: commit newly generated cassettes to their respective folder

tests: update latest fixtures with master

fix: update .gitattributes with updated path to cassettes

fix: use cassettes from master instead of generating them myself

fix: update path in .gitattributes

fix: make sure to match default functionality by using test name for cassette directory

fix: actually add git submodule

ci: checkout git submodules in CI

ci: update git submodules separately to ensure it gets called

feat: add a hooks directory so we can update git submodules on post-checkout

feat: make sure we push the tests/cassettes submodule on merge into master

ci: remove unused code now that we are using git submodules to keep cassettes in sync

fix: simplify how we load the submodule and fix updating cassettes on merge to master

chore: remove echo of checkout hook, it's unneeded

ci: remove unneccesary step
@waynehamadi
cassettes submodule
a670368
@waynehamadi waynehamadi force-pushed the create-cassette-submodule branch from ee1ab8a to a670368 Compare May 26, 2023 18:09
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 12 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@vercel
Copy link

vercel bot commented May 26, 2023

Deployment failed with the following error:

Resource is limited - try again in 5 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi merged commit e7c0d33 into Significant-Gravitas:master May 26, 2023
@waynehamadi waynehamadi mentioned this pull request May 29, 2023
Closed
12 tasks
@Pwuts Pwuts mentioned this pull request May 30, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-boikov k-boikov k-boikov approved these changes

Assignees
No one assigned
Labels
size/xl
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynehamadi @k-boikov @BaseInfinity