-
Notifications
You must be signed in to change notification settings - Fork 44.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve browse_website by using a hidden browser instance #1744
Improve browse_website by using a hidden browser instance #1744
Conversation
@BillSchumacher @nponeccop a review would be appreciated, thanks! |
22e6da4
to
cca2131
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't try running it. But it seems that it works exactly as described. Would be nice to see the headless flag was introduced in .env configuration
@jacobtohahn There are conflicts now |
@yudikubota Interesting, when I ran it it worked with no errors. I'll look into that. @nponeccop Thanks, will resolve |
@jacobtohahn PR #1670 proposes the |
@jacobtohahn There are conflicts now |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Is this PR still relevant after the fixes of the past few days? Like #1473 |
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
probably not... (at least AFAIK) |
Support for using a hidden browser was added in #1473. We don't keep the browser open, but I don't see the added value of that overall, since there are plenty of cases in which the browser is not used very much, and keeping it open would just be a waste of resources there. We might reconsider in the future, but for now I'm closing this PR. Thanks for submitting though! |
Background
Currently, the browse_website command creates a browser instance on top of all windows and then closes it when it's done. In order to prevent the user from being interrupted from other tasks on their computer, we could start a hidden browser instance when the browse_website command is run for the first time and leave it open for the duration of the AutoGPT session.
Changes
The web_selenium.py file was modified to implement the functionality described above. This creates a hidden browser instance when the browse_website command is run for the first time, and it is left open for the duration of the AutoGPT session.
Documentation
Test Plan
After instructing AutoGPT to browse various webpages, the functionality seems to work fine.
PR Quality Checklist