correctly set the path for Dockerfile and docker-compose in order to … #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a regression as it no longer mounts the scripts volume directory into the container from the host. In other words, you can't easily edit the code inside the container when debugging. |
|
The underlying issue here will be resolved by #1199 |
|
The issue is already managed by previous PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
"docker-compose up" introduces following error:
System: Ubuntu 20.04
Changes
Correctly set script in a subfolder of the appuser, and modify the mounting volume in docker-compose correspondingly.
Documentation
"docker-compose up" can be run successfully
Test Plan
"docker-compose up"
PR Quality Checklist