Multi line parameters #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haggaret
reviewed
Jan 8, 2020
parameter_sync.py
Outdated
| if 'Parameters' in result: | ||
| parameter_list = result['Parameters'] | ||
| for parameter_name in parameter_names_list: | ||
| result = ssm.get_parameters(Names=[parameter_name], WithDecryption=True) |
There was a problem hiding this comment.
If you're only going to get one at a time, why not use get_parameter instead of get_parameters?
For the record, this seems to be WAY less efficient than sending a list of parameter names. If there is a limit to how many parameters you can put in the list (not documented, but clearly a problem) then why not break up the list in chunks of size X and call this method multiple times?
There was a problem hiding this comment.
I've changed it to get_parameter.
This is much less efficient, but the get_paramter call is very quick.
haggaret
approved these changes
Jan 8, 2020
miketypeguy
approved these changes
Jan 8, 2020
| @@ -47,7 +50,7 @@ def process_parameter(param_name, param_value): | |||
| new_file_full_path = temp_dir + os.sep + filename + '.new' | |||
| logging.debug('Storing retrieved value for parameter "%s" in "%s"' % (param_name, new_file_full_path)) | |||
| with open(new_file_full_path, 'w') as f: | |||
| f.write(param_value.replace('\\n', '\n')) | |||
| f.write(param_value) | |||
There was a problem hiding this comment.
Hmm this should still work with files that did have unescaped new lines so that's good.
wjia7
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to Python 3.8, don't do the newline replacement in text of secrets, and handle more than 10 secrets.